Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable S3 access #332
+11
−2
Conversation
jrwiebe
added some commits
Jul 23, 2019
ianmilligan1
approved these changes
Jul 25, 2019
|
Tested yesterday with data held in a us-west-2 bucket and it worked flawlessly. Great work, @jrwiebe!
|
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jul 25, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
========================================
+ Coverage 74.97% 75% +0.02%
========================================
Files 39 39
Lines 1123 1124 +1
Branches 197 197
========================================
+ Hits 842 843 +1
Misses 215 215
Partials 66 66
Continue to review full report at Codecov.
|
ruebot
approved these changes
Jul 25, 2019
ruebot
merged commit 64c1f1f
into
master
Jul 25, 2019
ruebot
deleted the
s3
branch
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jrwiebe commentedJul 25, 2019
This PR responds to issue #319. It enables access to data stored in S3 by including necessary dependencies, and changing how the FileSystem is detected in
RecordLoader.loadArchives. See the issue discussion for a description of the two scenarios where AWS authentication currently fails due to reliance on an outdated version of Hadoop (i.e., use of temporary credentials, and Signature Version 4). This can be tested with the example code provided in the issue.