Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discardLanguage filter to RecordLoader. #353

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@ruebot
Copy link
Member

commented Aug 21, 2019

GitHub issue(s): #352

What does this Pull Request do?

  • Clean up doc comments
  • Add test
  • Resolves #352

How should this be tested?

  • New unit test + TravisCI should do it
Add discardLanguage filter to RecordLoader.
- Clean up doc comments
- Add test
- Resolves #352

@ruebot ruebot requested a review from ianmilligan1 Aug 21, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 22, 2019

Codecov Report

Merging #353 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   75.91%   75.93%   +0.01%     
==========================================
  Files          39       39              
  Lines        1387     1388       +1     
  Branches      265      266       +1     
==========================================
+ Hits         1053     1054       +1     
  Misses        218      218              
  Partials      116      116

@ianmilligan1 ianmilligan1 merged commit 0284d33 into master Aug 23, 2019

3 checks passed

codecov/patch 100% of diff hit (target 75.91%)
Details
codecov/project 75.93% (+0.01%) compared to bced854
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.