Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/aut-docs-new

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary analysis #11

Merged
merged 1 commit into from Oct 26, 2019
+1,152 −6

Conversation

@ruebot
Copy link
Member

ruebot commented Oct 25, 2019

  • Frame out a structure for binary analysis and extraction
  • Add Scala DF and Python DF version of extractImageLinks

Please provide feedback on this structure. If this is what y'all are looking for, I'll continue adding the remaining binary extraction examples.

Or, if you have a better way, feel free to push.
@ruebot ruebot requested review from lintool and ianmilligan1 Oct 25, 2019
@lintool
lintool reviewed Oct 25, 2019
View changes
current/binary-analysis.md Outdated Show resolved Hide resolved
@lintool
lintool reviewed Oct 25, 2019
View changes
current/image-analysis.md Outdated Show resolved Hide resolved
@lintool
lintool reviewed Oct 25, 2019
View changes
current/image-analysis.md Outdated Show resolved Hide resolved
@ianmilligan1
ianmilligan1 approved these changes Oct 25, 2019
View changes
Copy link
Member

ianmilligan1 left a comment

Looking great - this approach is perfect to me!
@ruebot ruebot force-pushed the binary-analysis branch from a808228 to 68a4e62 Oct 25, 2019
@ruebot ruebot marked this pull request as ready for review Oct 25, 2019
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

ruebot commented Oct 25, 2019

@lintool @ianmilligan1 ready for final review.
@lintool lintool self-requested a review Oct 25, 2019
@lintool

This comment has been minimized.

Sign in to view
Copy link
Member

lintool commented Oct 25, 2019

lgtm! (since I'm an author on this PR, I can't review myself....)
@lintool
lintool approved these changes Oct 25, 2019
View changes
@ruebot
Add binary analysis
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
a60e3ab 
- Add documentation for binary analysis and extraction in Scala DF and
Python DF
- Add Scala DF and Python DF version of extractImageLinks
- Update main ToC
@ruebot ruebot force-pushed the binary-analysis branch from 68a4e62 to a60e3ab Oct 26, 2019
@ruebot ruebot merged commit 978d0ab into master Oct 26, 2019
@ruebot ruebot deleted the binary-analysis branch Oct 26, 2019
ruebot added a commit that referenced this pull request Oct 26, 2019
@ruebot
Update to ToC to be more consistent after #11.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
ae4949b
ianmilligan1 added a commit that referenced this pull request Oct 26, 2019
@ruebot @ianmilligan1
Update to ToC to be more consistent after #11. (#13)
48c1331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lintool lintool

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @lintool @ianmilligan1
You can’t perform that action at this time.