Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Doc for Latest Changes #19

Merged
merged 9 commits into from Nov 7, 2019

Conversation

@SinghGursimran
Copy link
Contributor

SinghGursimran commented Nov 7, 2019

No description provided.

Copy link
Member

ruebot left a comment

Just a couple changes, other than that. Good to go.

.saveAsTextFile("plain-text-noheaders/")
```

As most plain text use cases do not require HTTP headers to be in the output, we are removing headers in the following examples.

### Scala DF

TODO
```scala

This comment has been minimized.

Copy link
@ruebot

ruebot Nov 7, 2019

Member

Let's change this so it is consistent with the others:

import io.archivesunleashed._
import io.archivesunleashed.df._

RecordLoader.loadArchives("example.warc.gz", sc)
  .extractValidPagesDF()
  .select(RemoveHTML($"content"))
  .write
  .option("header","true")
  .csv("plain-text-noheaders/")
import io.archivesunleashed._
import io.archivesunleashed.df._
RecordLoader.loadArchives("src/test/resources/warc/example.warc.gz", sc).extractValidPagesDF()

This comment has been minimized.

Copy link
@ruebot

ruebot Nov 7, 2019

Member

We can strip out: src/test/resources/warc/ here.

@ruebot
ruebot approved these changes Nov 7, 2019
@ruebot ruebot merged commit 4f73504 into archivesunleashed:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.