Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create les-nouvelles-de-l-archeologie.csl #4335

Merged
merged 4 commits into from Oct 9, 2019
+181 −0

Conversation

@sebastien-plutniak
Copy link
Contributor

commented Oct 6, 2019

Creation of the style (no template).
@sebastien-plutniak
Create les-nouvelles-de-l-archeologie.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
51fb32c 
Creation of the style (no template).
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 6, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 6, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

les-nouvelles-de-l-archeologie.csl (new)
2012 ; Hancké et al. 2007
Fenner et al. 2019 ; Mares 2001
2012. « CSL search by example », Citation Style Editor. http://editor.citationstyles.org/searchByExample/.
Fenner M., Crosas M., Grethe J.S., Kennedy D., Hermjakob H., Rocca-Serra P., Durand G., Berjon R., Karcher S., Martone M. & Clark T.. 2019. « A data citation roadmap for scholarly data repositories », Scientific Data, 6, 1 : 28. DOI : 10.1038/s41597-019-0031-8 ; http://www.nature.com/articles/s41597-019-0031-8.
Hancké B., Rhodes M. & Thatcher M.. 2007. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York, Oxford University Press.
Mares I.. 2001. « Firms and the welfare state: When, why, and how does social policy matter to employers? », in : Hall P.A., Soskice D. (éds.) , Varieties of capitalism. The institutional foundations of comparative advantage. New York, Oxford University Press : 184‑213.
@rmzelle
Update les-nouvelles-de-l-archeologie.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8679149
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 7, 2019

Thanks! Did you base this on an existing CSL style? If so, we'd like to know which one, so we can add a "template" link (see https://github.com/citation-style-language/styles/wiki/Style-Requirements#8---template-link)
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 7, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

les-nouvelles-de-l-archeologie.csl (new)
2012 ; Hancké et al. 2007
Fenner et al. 2019 ; Mares 2001
2012. « CSL search by example », Citation Style Editor. http://editor.citationstyles.org/searchByExample/.
Fenner M., Crosas M., Grethe J.S., Kennedy D., Hermjakob H., Rocca-Serra P., Durand G., Berjon R., Karcher S., Martone M. & Clark T.. 2019. « A data citation roadmap for scholarly data repositories », Scientific Data, 6, 1 : 28. DOI : 10.1038/s41597-019-0031-8 ; http://www.nature.com/articles/s41597-019-0031-8.
Hancké B., Rhodes M. & Thatcher M.. 2007. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York, Oxford University Press.
Mares I.. 2001. « Firms and the welfare state: When, why, and how does social policy matter to employers? », in : Hall P.A., Soskice D. (éds.) , Varieties of capitalism. The institutional foundations of comparative advantage. New York, Oxford University Press : 184‑213.
@sebastien-plutniak

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 7, 2019

Let say I re-used and adapted the file I used to create the prehistoires-mediterraneennes.csl or the organon.csl files… but I am not sure I means I used them as a proper template.
@adam3smith
adam3smith requested changes Oct 8, 2019
View changes
Copy link
Member

left a comment

Some comments/change request. Note that you can't actually just accept the suggestions, since github doesn't have multi-line suggestions yet.

@rmzelle I'm OK taking this without template since it's all based on his own styles.
les-nouvelles-de-l-archeologie.csl Outdated Show resolved Hide resolved
les-nouvelles-de-l-archeologie.csl Outdated Show resolved Hide resolved
les-nouvelles-de-l-archeologie.csl Outdated
<names variable="editor">
<name and="symbol" name-as-sort-order="all" font-variant="small-caps" sort-separator=" " delimiter=", " delimiter-precedes-last="never" initialize-with="."/>
<substitute>
<names variable="editorial-director" font-variant="small-caps"/>
</substitute>
</names>
Beta Send feedback
Comment for lines 57  – 62

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Oct 8, 2019

Member
Suggested change
</names>
<names variable="editor"/>
<names variable="editorial-director"/>

should do the same

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Oct 8, 2019

Member

actually it'll give you a label such as "eds." for editors, which I think you want.

This comment has been minimized.

Sign in to view
Copy link
@sebastien-plutniak

sebastien-plutniak Oct 9, 2019

Author Contributor

Sorry, I don't understand this point (and haven't change these lines in the new version)

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Oct 9, 2019

Member

Why are you using this complicated construct with two nested substitutes rather than just

<substitute>
  <names variable="editor"/>
  <names variable="editorial-director"/>
</substitute>

which isn't just cleaner, it should also produce more accurate output. If you check the current generated samples, the edited volume (Hancke et al.) doesn't have an editor label for editors, which is almost certainly incorrect.

This comment has been minimized.

Sign in to view
Copy link
@sebastien-plutniak

sebastien-plutniak Oct 9, 2019

Author Contributor

Thanks, now I got it. I modified the file as you suggest.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 8, 2019

Is this a duplicate of #4293 ?
@sebastien-plutniak
Update les-nouvelles-de-l-archeologie.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f2474c4 
nodate value and journal-issue macro modified.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 9, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

les-nouvelles-de-l-archeologie.csl (new)
2012 ; Hancké et al. 2007
Fenner et al. 2019 ; Mares 2001
2012. « CSL search by example », Citation Style Editor. http://editor.citationstyles.org/searchByExample/.
Fenner M., Crosas M., Grethe J.S., Kennedy D., Hermjakob H., Rocca-Serra P., Durand G., Berjon R., Karcher S., Martone M. & Clark T.. 2019. « A data citation roadmap for scholarly data repositories », Scientific Data, 6, 1 : 28. DOI : 10.1038/s41597-019-0031-8 ; http://www.nature.com/articles/s41597-019-0031-8.
Hancké B., Rhodes M. & Thatcher M.. 2007. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York, Oxford University Press.
Mares I.. 2001. « Firms and the welfare state: When, why, and how does social policy matter to employers? », in : Hall P.A., Soskice D. (éds.) , Varieties of capitalism. The institutional foundations of comparative advantage. New York, Oxford University Press : 184‑213.
@sebastien-plutniak

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 9, 2019

Yes, indeed, it is a duplicate (I've forgot I submitted it early September) I close the pull request #4293.
@sebastien-plutniak
Update les-nouvelles-de-l-archeologie.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
96c186d 
use of “substitute” corrected
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 9, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

les-nouvelles-de-l-archeologie.csl (new)
2012 ; Hancké et al. 2007
Fenner et al. 2019 ; Mares 2001
2012. « CSL search by example », Citation Style Editor. http://editor.citationstyles.org/searchByExample/.
Fenner M., Crosas M., Grethe J.S., Kennedy D., Hermjakob H., Rocca-Serra P., Durand G., Berjon R., Karcher S., Martone M. & Clark T.. 2019. « A data citation roadmap for scholarly data repositories », Scientific Data, 6, 1 : 28. DOI : 10.1038/s41597-019-0031-8 ; http://www.nature.com/articles/s41597-019-0031-8.
Hancké B., Rhodes M. & Thatcher M. (éds.). 2007. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York, Oxford University Press.
Mares I.. 2001. « Firms and the welfare state: When, why, and how does social policy matter to employers? », in : Hall P.A., Soskice D. (éds.) , Varieties of capitalism. The institutional foundations of comparative advantage. New York, Oxford University Press : 184‑213.
@adam3smith
adam3smith approved these changes Oct 9, 2019
View changes
@adam3smith adam3smith merged commit 8e5adb0 into citation-style-language:master Oct 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 9, 2019

Great, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sebastien-plutniak @csl-bot @rmzelle @adam3smith
You can’t perform that action at this time.