Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harvard-university-for-the-creative-arts.csl #4360

Merged
merged 2 commits into from Oct 17, 2019

Conversation

@ibadger
Copy link
Contributor

commented Oct 15, 2019

Sorry to open a new pull request but when this was closed the other day when an edited book (not chapter) was referenced in a bibliography the ed. or eds. after the name was no longer within brackets.
It is producing this:
Hancké, B. et al. eds. (2007) Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
When it should be this:
Hancké, B. et al. (eds.) (2007) Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
I use the visual editor and when I amended the names variable to the macro editor it fixed this issue.
Is this change ok, or is there a different way that it should be done?

Sorry to open a new pull request but when this was closed the other day when an edited book (not chapter) was referenced in a bibliography the ed. or eds. after the name was no longer within brackets.
It is producing this: 
Hancké, B. et al. eds. (2007) Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
When it should be this:
Hancké, B. et al. (eds.) (2007) Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
I use the visual editor and when I amended the names variable to the macro editor it fixed this issue.
Is this change ok, or is there a different way that it should be done?
@csl-bot

This comment has been minimized.

Copy link

commented Oct 15, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Oct 15, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

harvard-university-for-the-creative-arts.csl (modified style)
(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example (2012) At: http://editor.citationstyles.org/searchByExample/ (Accessed 15/12/2012).
Fenner, M. et al. (2019) 'A data citation roadmap for scholarly data repositories' In: Scientific Data 6 (1) p.28. At: http://www.nature.com/articles/s41597-019-0031-8 (Accessed 27/04/2019).
Hancké, B. et al. (eds.) (2007) Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. (2001) 'Firms and the welfare state: When, why, and how does social policy matter to employers?' In: Hall, P.A. and Soskice, D. (eds.) Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press. pp.184–213.
 (Hancké <i>et al.</i>, 2007; CSL search by example, 2012)<br/>
 (Mares, 2001; Fenner <i>et al.</i>, 2019)<br/>
 <hr/>
 <i>CSL search by example</i> (2012) At: http://editor.citationstyles.org/searchByExample/ (Accessed 15/12/2012).<br/>
 Fenner, M. <i>et al.</i> (2019) 'A data citation roadmap for scholarly data repositories' In: <i>Scientific Data</i> 6 (1) p.28. At: http://www.nature.com/articles/s41597-019-0031-8 (Accessed 27/04/2019).<br/>
-Hancké, B. <i>et al.</i> eds. (2007) <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press.<br/>
+Hancké, B. <i>et al.</i> (eds.) (2007) <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press.<br/>
 Mares, I. (2001) 'Firms and the welfare state: When, why, and how does social policy matter to employers?' In: Hall, P.A. and Soskice, D. (eds.) <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>. New York: Oxford University Press. pp.184–213.<br/>
@csl-bot

This comment has been minimized.

Copy link

commented Oct 16, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

harvard-university-for-the-creative-arts.csl (modified style)
(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example (2012) At: http://editor.citationstyles.org/searchByExample/ (Accessed 15/12/2012).
Fenner, M. et al. (2019) 'A data citation roadmap for scholarly data repositories' In: Scientific Data 6 (1) p.28. At: http://www.nature.com/articles/s41597-019-0031-8 (Accessed 27/04/2019).
Hancké, B. et al. (eds.) (2007) Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. (2001) 'Firms and the welfare state: When, why, and how does social policy matter to employers?' In: Hall, P.A. and Soskice, D. (eds.) Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press. pp.184–213.
 (Hancké <i>et al.</i>, 2007; CSL search by example, 2012)<br/>
 (Mares, 2001; Fenner <i>et al.</i>, 2019)<br/>
 <hr/>
 <i>CSL search by example</i> (2012) At: http://editor.citationstyles.org/searchByExample/ (Accessed 15/12/2012).<br/>
 Fenner, M. <i>et al.</i> (2019) 'A data citation roadmap for scholarly data repositories' In: <i>Scientific Data</i> 6 (1) p.28. At: http://www.nature.com/articles/s41597-019-0031-8 (Accessed 27/04/2019).<br/>
-Hancké, B. <i>et al.</i> eds. (2007) <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press.<br/>
+Hancké, B. <i>et al.</i> (eds.) (2007) <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press.<br/>
 Mares, I. (2001) 'Firms and the welfare state: When, why, and how does social policy matter to employers?' In: Hall, P.A. and Soskice, D. (eds.) <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>. New York: Oxford University Press. pp.184–213.<br/>
@adam3smith adam3smith merged commit 2c668df into citation-style-language:master Oct 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Oct 17, 2019

Thanks (I changed the coding of this, but same outcome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.