Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archiv with perma.cc returns invalid dataframe #24

Closed
adam3smith opened this issue Mar 1, 2019 · 1 comment

Comments

@adam3smith
Copy link
Contributor

commented Mar 1, 2019

Example:

r <- archiv(c("https://www.google.com", "NOT a URL", "https://qdr.syr.edu"), method="perma_cc")
[[1]]
[1] "https://www.google.com"                                           
[2] "5RVF-7BCE"                                                        
[3] "2019-03-02T21:31:15.669256Z"                                      
[4] "//perma-archives.org/warc/5RVF-7BCE/https://www.google.com"       
[5] "//perma-archives.org/warc/5RVF-7BCE/id_/file:///5RVF-7BCE/cap.png"
[6] "https://perma.cc/5RVF-7BCE"                                       

[[2]]
[1] "Not a valid URL."  "https://perma.cc/"

[[3]]
[1] "https://qdr.syr.edu"                                              
[2] "TYZ8-H8P5"                                                        
[3] "2019-03-02T21:31:17.061622Z"                                      
[4] "//perma-archives.org/warc/TYZ8-H8P5/https://qdr.syr.edu"          
[5] "//perma-archives.org/warc/TYZ8-H8P5/id_/file:///TYZ8-H8P5/cap.png"
[6] "https://perma.cc/TYZ8-H8P5"                                       

Error in names(x) <- value : 
  'names' attribute [6] must be the same length as the vector [5]

The problem being that the vector for the "Not a URL" line is too short. It needs to be the same length as a successful save

@adam3smith adam3smith added the bug label Mar 1, 2019
@greebie greebie self-assigned this Mar 2, 2019
@greebie

This comment has been minimized.

Copy link
Collaborator

commented Mar 2, 2019

Suggested fix: create default empty row for failed url (like with WayBack). Will look into this over the weekend hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.