Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perma_cc bug #24 #26

Merged
merged 3 commits into from Oct 17, 2019

Conversation

@greebie
Copy link
Collaborator

commented Mar 10, 2019

The main issue was not as I suspected, but it was that the if--else was not being properly satisfied when the "NOT A URL" was being sent to the API.

NOTE: the latest commit may create another error for QDR's account, because the QDR account has multiple root rows as per #25 . If it does create a problem, I think it would be best to fix that issue in this PR too.

@greebie

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 10, 2019

Not sure why it failed AppVeyor - something about pdftools not running properly.

@greebie greebie requested a review from adam3smith Mar 19, 2019
@adam3smith

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Sorry this took a while, but this doesn't work for me and it almost looks like you reverted your fix in the second commit above? Output:

r <- archiv(c("https://www.google.com", "NOT a URL", "https://qdr.syr.edu"), method="perma_cc")
[1] "pass"
[1] "pass"
[1] "pass"
Error in names(x) <- value : 
  'names' attribute [6] must be the same length as the vector [5]
In addition: Warning message:
In matrix(unlist(newlst), nrow = length(newlst), byrow = T) :
  data length [14] is not a sub-multiple or multiple of the number of rows [3]
@adam3smith

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Also, as you suspect, get_default_folder() doesn't work. The above is after setting a folder ID. Before doing so I get:

r <- archiv(c("https://www.google.com", "NOT a URL", "https://qdr.syr.edu"), method="perma_cc")
[1] "Setting folder based on api key."
Error in get_default_folder()[1, ] : incorrect number of dimensions
@adam3smith

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2019

@greebie if you do work on this on Monday, could you take another look at this?

@greebie

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 16, 2019

Hi Sebastian - I think this is working as it is now. It requires that you use set_folder_id("id of selected folder") to work.

Don't forget to delete my useless links in your account please!

@adam3smith adam3smith merged commit bb189bd into master Oct 17, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.