Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upExtractDomain or ExtractBaseDomain? #367
Comments
This comment has been minimized.
This comment has been minimized.
Let's go with |
This comment has been minimized.
This comment has been minimized.
Shall we just rename it to |
This comment has been minimized.
This comment has been minimized.
Any reason why you want the |
This comment has been minimized.
This comment has been minimized.
Oh, just keeping it consistent with how we've done the same with the other DF functions like here ...I'm happy to keep it uniform too. |
This comment has been minimized.
This comment has been minimized.
Although per #366 we would rename that to just |
This comment has been minimized.
This comment has been minimized.
Okay, so stick to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
lintool commentedOct 25, 2019
In Scala RDD, we have:
In Scala DF, we have:
We should be consistent:
ExtractDomain
orExtractBaseDomain
?