Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: perccalc: An R package for estimating percentiles from categorical variables #1796
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @briatte, @amoeba it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
BTW, @briatte, thanks for volunteering to review! (I took you at your word...) |
This comment has been minimized.
This comment has been minimized.
@majensen No problem. I'm planning to review the package next week, probably Thursday or Friday. |
This comment has been minimized.
This comment has been minimized.
Hey @majensen, @cimentadaj, I've conducted my first pass at the review checklist and things look very good overall. I have some items I'd like @cimentadaj to address so at this point my review is a conditional accept. See: cimentadaj/perccalc#2. |
This comment has been minimized.
This comment has been minimized.
Hi @majensen, @cimentadaj and @amoeba I'm also done with my review: conditional accept with very minor revisions, some of which are nitpicky to the point that @cimentadaj might reasonably decide to ignore them entirely. @amoeba -- There's a small risk that I might have accidentally checked one item on your review list. I'm very sorry for that -- please accept my apologies: I'm still learning to do JOSS reviews, plus it was early morning and I had had only one coffee (this has been fixed since). |
This comment has been minimized.
This comment has been minimized.
Hi everyone Thanks for the reviews. I'm probably gonna check them out first week of November and finish them at that time. Is that good? |
This comment has been minimized.
This comment has been minimized.
@cimentadaj sounds good to me. That accords with my schedule too :D |
This comment has been minimized.
This comment has been minimized.
I've answered to all comments from both reviewers here. As I outlined there, I'm happy to review some points if they feel like their points weren't addressed. Thank you both for reviewing the paper/package, the comments have been very helpful to ship the next version to CRAN flawlessly! |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@briatte, @amoeba -- based on @cimentadaj comments at issue 2, are you guys prepared to check off the remaining boxes? |
This comment has been minimized.
This comment has been minimized.
@majensen, we're almost there. Still elucidating whether we keep/remove the example section. I think we'll have this figured out by the end of the week. |
This comment has been minimized.
This comment has been minimized.
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@majensen my review is now an Accept after @cimentadaj 's recent change to the paper, removing the examples, as per cimentadaj/perccalc#2 (comment). |
This comment has been minimized.
This comment has been minimized.
Same here, I'm also Accept at that stage. |
This comment has been minimized.
This comment has been minimized.
@amoeba and @briatte thanks very much; and thanks @cimentadaj for your hard work and responsiveness. I will perform my final proofreading tasks - might lead to a PR - and then will make the formal recommendation. |
This comment has been minimized.
This comment has been minimized.
(right after @cimentadaj merges the review branch...) |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@cimentadaj : created cimentadaj/perccalc#7 with some minor edits |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@cimentadaj - Here are the final steps. Can I get you to create a tag for the latest master, and then archive that tag with Zenodo or similar? Then please provide the DOI from the archive in this thread. I will push the recommendation from there to the editors-in-chief. |
This comment has been minimized.
This comment has been minimized.
(BTW, here's an overview for Zenodo, if you haven't used it before: #1839 (comment)) |
This comment has been minimized.
This comment has been minimized.
Thanks, the DOI is 10.5281/zenodo.3559855 and can be found here. |
This comment has been minimized.
This comment has been minimized.
@openjournals/joss-eics, I recommend this paper for publication and ask that you begin the final steps. Thanks! |
This comment has been minimized.
This comment has been minimized.
Thanks - will do shortly |
This comment has been minimized.
This comment has been minimized.
@majensen - if you can tell whedon the archive and version, that helps the AEiC... (See https://joss.readthedocs.io/en/latest/editing.html#after-reviewers-recommend-acceptance) |
This comment has been minimized.
This comment has been minimized.
Thanks @danielskatz will do |
This comment has been minimized.
This comment has been minimized.
@whedon set 10.5281/zenodo.3559855 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.3559855 is the archive. |
This comment has been minimized.
This comment has been minimized.
@whedon set v1.0.5 as version |
This comment has been minimized.
This comment has been minimized.
OK. v1.0.5 is the version. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
whedon commentedOct 10, 2019
•
edited
Submitting author: @cimentadaj (Jorge Cimentada)
Repository: https://github.com/cimentadaj/perccalc/
Version: v1.0.5
Editor: @majensen
Reviewer: @briatte, @amoeba
Archive: 10.5281/zenodo.3559855
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@briatte & @amoeba, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @majensen know.
Review checklist for @briatte
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @amoeba
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper