Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ggalluvial: Layered Grammar for Alluvial Plots #1937

Open
whedon opened this issue Dec 6, 2019 · 18 comments
Assignees
Labels

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Dec 6, 2019

Submitting author: @corybrunson (Jason Cory Brunson)
Repository: https://github.com/corybrunson/ggalluvial
Version: v0.11.1
Editor: @akeshavan
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @corybrunson. The JOSS editor @akeshavan, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@corybrunson if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 6, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @akeshavan it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@akeshavan) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 6, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 6, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon whedon added R TeX labels Dec 6, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 6, 2019

Failed to discover a valid open source license.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 6, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 6, 2019


OK DOIs

- 10.1007/978-4-431-68057-4_3 is OK
- 10.1080/01621459.1990.10474926 is OK
- 10.1198/106186002317375631 is OK
- 10.1109/INFVIS.2005.1532152 is OK
- 10.1007/3-540-28084-7_4 is OK
- 10.1109/TVCG.2006.76 is OK
- 10.1111/j.1530-9290.2008.00004.x is OK
- 10.1198/jcgs.2009.07098 is OK
- 10.1371/journal.pone.0008694 is OK
- 10.1109/TVCG.2011.227 is OK
- 10.1007/978-3-642-21551-3_13 is OK
- 10.1068/a45488 is OK
- 10.1109/TVCG.2013.140 is OK
- 10.18637/jss.v059.i10 is OK
- 10.1038/srep06773 is OK
- 10.1007/978-0-387-98141-3 is OK
- 10.1177/0308518X17745067 is OK
- 10.1016/j.anaerobe.2018.05.017 is OK
- 10.21105/joss.01686 is OK
- 10.31234/OSF.IO/MKQN4 is OK
- 10.1002/ejhf.1547 is OK
- 10.1111/gec3.12441 is OK
- 10.1523/jneurosci.1451-18.2019 is OK
- 10.3389/fimmu.2019.00660 is OK
- 10.1097/CCM.0000000000003469 is OK
- 10.1016/j.marpol.2019.103676 is OK
- 10.1016/j.eiar.2019.01.003 is OK
- 10.1016/j.fcr.2019.03.023 is OK

MISSING DOIs

- https://doi.org/10.1007/0-387-28695-0 may be missing for title: The Grammar of Graphics

INVALID DOIs

- None
@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 6, 2019

👋 @akeshavan - sorry, I assigned this to you while starting the process without checking with you first. Are you willing to edit this submission?

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 6, 2019

👋 @corybrunson - this submission needs a license - please add a plain text LICENSE file with the OSI-approved license that you are using for the software (which I think is GPL-3).

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 6, 2019

Also, please check to see if the missing DOI whedon suggests is correct, and if so, add it to the .bib file. (Whedon suggestions are just suggestions, and sometimes they are wrong.)

@corybrunson

This comment has been minimized.

Copy link
Collaborator

@corybrunson corybrunson commented Dec 6, 2019

@danielskatz thank you! I've added the missing DOI. To be sure, is it good practice to simply put the standard GPLv3 license text (file name LICENSE) in the root directory, assuming i don't intend any deviations from that standard?

@corybrunson

This comment has been minimized.

Copy link
Collaborator

@corybrunson corybrunson commented Dec 6, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 6, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 6, 2019

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 6, 2019

To be sure, is it good practice to simply put the standard GPLv3 license text (file name LICENSE) in the root directory, assuming i don't intend any deviations from that standard?

Yes, and if there are any deviations, you have changed the license to a non-OSI-approved one, which would mean that JOSS would not consider the submission.

@corybrunson

This comment has been minimized.

Copy link
Collaborator

@corybrunson corybrunson commented Dec 6, 2019

Yes, and if there are any deviations, you have changed the license to a non-OSI-approved one, which would mean that JOSS would not consider the submission.

Right, thank you for pointing that out. In a moment i'll push the Markdown GPLv3 obtained from here, renamed LICENSE.md.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 6, 2019

not LICENSE.md but LICENSE

@corybrunson

This comment has been minimized.

Copy link
Collaborator

@corybrunson corybrunson commented Dec 6, 2019

not LICENSE.md but LICENSE

Thank you, this has been changed (using the plain text version of GPLv3).

@corybrunson

This comment has been minimized.

Copy link
Collaborator

@corybrunson corybrunson commented Dec 6, 2019

From the list of potential reviewers, @kellieotto, @njtierney, and @clauswilke seem to have very relevant expertise and interests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.