Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: rgsp: An R Package for Quality Control Charts under Repetitive Group Sampling Plan based on Cpk #1927

Closed
whedon opened this issue Dec 2, 2019 · 10 comments
Labels

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Dec 2, 2019

Submitting author: @myaseen208 (Muhammad Yaseen)
Repository: https://github.com/myaseen208/rgsp_article
Version: 0.2.0
Editor: Pending
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @myaseen208. Currently, there isn't an JOSS editor assigned to your paper.

@myaseen208 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Dec 2, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

Failed to discover a valid open source license.

@whedon whedon added the TeX label Dec 2, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019


OK DOIs

- None

MISSING DOIs

- https://doi.org/10.1080/02664760500446010 may be missing for title: Repetitive group sampling procedure for variables inspection
- https://doi.org/10.1080/00401706.1965.10490222 may be missing for title: Design and evaluation of a repetitive group sampling plan
- https://doi.org/10.1109/access.2016.2620241 may be missing for title: Capability indices for non-normal distribution using Gini’s mean difference as measure of variability
- https://doi.org/10.1016/j.omega.2005.01.018 may be missing for title: An effective decision making method for product acceptance
- https://doi.org/10.1016/j.ejor.2006.11.032 may be missing for title: A variables sampling plan based on Cpmk for product acceptance determination

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 2, 2019

👋 @myaseen208 - I don't see any software to be reviewed in the repository you indicated. Where is the software? You've also submitted .pdf and .log files for paper, which don't need to be in the repository.

@myaseen208

This comment has been minimized.

Copy link

@myaseen208 myaseen208 commented Dec 3, 2019

@danielskatz - software is here https://github.com/myaseen208/rgsp. Should I keep both software and paper in the same repository.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 3, 2019

Yes - you should probably withdraw this submission, and add the paper (.md and .bib files only) to the repo that contains the software, then make a new submission with the repo that will then contain both the software and the paper.

In addition, I see some issues when I look at the source repo: https://github.com/myaseen208/rgsp

  • There is no LICENSE file
  • The README doesn't contain enough context about the software, such as what kinds of research it is used in
  • The code looks fairly small - there is some chance this will be considered a minor utility, out of scope for JOSS

Overall, please review the submission instructions in https://joss.readthedocs.io/en/latest/submitting.html carefully before making a new submission

@myaseen208

This comment has been minimized.

Copy link

@myaseen208 myaseen208 commented Dec 3, 2019

@danielskatz - Thanks for your guidance. Followed the instructions and needful done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.