Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/joss

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generated crossref XML missing linebreaks in citations #634

Closed
danielskatz opened this issue Nov 21, 2019 · 4 comments
Labels
bug

Comments

@danielskatz
Copy link
Collaborator

@danielskatz danielskatz commented Nov 21, 2019 •
edited

This makes it hard for an AEiC to check the xml file
For example,
joss.01891/10.21105.joss.01891.crossref.xml
in
https://github.com/openjournals/joss-papers/pull/1118/files
has

        <citation_list> <citation key="ref1"> <doi>10.1145/351240.351266</doi> </citation> <citation key="ref2"> <doi>10.1145/1159789.1159792</doi> </citation> <citation key="ref3"> <unstructured_citation>In Praise of Property-Bsed Testing, ://increment.com/testing/in-praise-of-property-based-testing/, 2019, MacIver, David R.</unstructured_citation> </citation> <citation key="ref4"> <doi>10.1109/32.988498</doi> </citation> <citation key="ref5"> <doi>10.1145/2254064.2254104</doi> </citation> <citation key="ref6"> <doi>10.3847/1538-3881/aabc4f</doi> </citation> <citation key="ref7"> <doi>10.1109/MCSE.2011.37</doi> </citation> <citation key="ref8"> <doi>10.1145/3092703.3092711</doi> </citation> </citation_list>
@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

@danielskatz danielskatz commented Dec 2, 2019

I notice that the same problem occurs with authors - all authors are on one line of the XML file. This really makes it hard to review in the github interface, which by default does not wrap the long lines that are being generated, and also, this makes it hard to check tags
@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

@arfon arfon commented Dec 3, 2019

Yeah, this is a recent change which is the result of trying to fix a long-standing issue with the encoding of data passed into Pandoc. I realize this is sub-optimal and will investigate how to address this.
@arfon arfon added the bug label Dec 3, 2019
@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

@arfon arfon commented Dec 5, 2019

This should be fixed by openjournals/whedon@cd7dade
@arfon arfon closed this Dec 5, 2019
@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

@danielskatz danielskatz commented Dec 6, 2019

thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@danielskatz @arfon
You can’t perform that action at this time.