Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing LICENSE file #49

Open
mado89 opened this issue Nov 7, 2019 · 3 comments

Comments

@mado89
Copy link

@mado89 mado89 commented Nov 7, 2019

Although the readme states the project served under MIT license this file is missing (required by the journal conventions: "Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?")

openjournals/joss-reviews#1845

@alessandroBombelli

This comment has been minimized.

Copy link
Owner

@alessandroBombelli alessandroBombelli commented Nov 7, 2019

Although the readme states the project served under MIT license this file is missing (required by the journal conventions: "Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?")

openjournals/joss-reviews#1845

Hi @mado89, maybe I am missing something, but I added a MIT license I think ---> This project is licensed under the MIT License.

@mado89

This comment has been minimized.

Copy link
Author

@mado89 mado89 commented Nov 7, 2019

Yes that information is present. But afaik I understand it you need a copy of the license present in your repo and not only the reference.
Maybe @danielskatz can clarify.

@danielskatz

This comment has been minimized.

Copy link
Contributor

@danielskatz danielskatz commented Nov 9, 2019

Yes, a LICENSE file is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.