Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd favicon #959
Comments
This comment has been minimized.
This comment has been minimized.
Are we able to do that? We do not have the top level of tools.wmflabs.org? |
This comment has been minimized.
This comment has been minimized.
Judging on the basis of things like https://tools.wmflabs.org/reasonator/ , there should be a way. |
This comment has been minimized.
This comment has been minimized.
I think I can get this done wednesday morning, I'm quite familiar with favicons |
This comment has been minimized.
This comment has been minimized.
Is there a urls.py file for in scholia? or how are pages served, I want to create a redirect for /favicon.ico to the static path Edit: Is this done through flask @main.route ? Edit: yes |
This comment has been minimized.
This comment has been minimized.
I am wondering whether HTML base tag could/should be used (too) |
This comment has been minimized.
This comment has been minimized.
Users are beginning to notice: https://twitter.com/GerardMeijssen/status/1202466066175266816 |
This comment has been minimized.
This comment has been minimized.
The favicon is now running. I had difficulty reviewing the code as I am not familiar with favicon. I thought it was just a question of putting something in the root directory, but I see it is somewhat more elaborate. |
This comment has been minimized.
This comment has been minimized.
Need to add a few more redirects but for 99% of real use cases it's fine :) |
This comment has been minimized.
This comment has been minimized.
Actually reading what that says, I don't know if we can fully resolve as we aren't serving our site from the / root domain. Therefore I don't think there is much that can be done but that's not a bad thing :) |
This comment has been minimized.
This comment has been minimized.
Looks good enough for the moment. Close? |
This comment has been minimized.
This comment has been minimized.
|
Daniel-Mietchen commentedDec 2, 2019
Perhaps using our logo as a starting point: https://commons.wikimedia.org/wiki/File:Scholia_logo.svg .