Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon #959

Open
Daniel-Mietchen opened this issue Dec 2, 2019 · 11 comments

Comments

@Daniel-Mietchen
Copy link
Collaborator

@Daniel-Mietchen Daniel-Mietchen commented Dec 2, 2019

Perhaps using our logo as a starting point: https://commons.wikimedia.org/wiki/File:Scholia_logo.svg .

@fnielsen

This comment has been minimized.

Copy link
Owner

@fnielsen fnielsen commented Dec 2, 2019

Are we able to do that? We do not have the top level of tools.wmflabs.org?

@Daniel-Mietchen

This comment has been minimized.

Copy link
Collaborator Author

@Daniel-Mietchen Daniel-Mietchen commented Dec 2, 2019

Judging on the basis of things like https://tools.wmflabs.org/reasonator/ , there should be a way.

@carlinmack

This comment has been minimized.

Copy link
Contributor

@carlinmack carlinmack commented Dec 3, 2019

I think I can get this done wednesday morning, I'm quite familiar with favicons

@carlinmack

This comment has been minimized.

Copy link
Contributor

@carlinmack carlinmack commented Dec 4, 2019

Is there a urls.py file for in scholia? or how are pages served, I want to create a redirect for /favicon.ico to the static path

Edit: Is this done through flask @main.route ?

Edit: yes

@fnielsen

This comment has been minimized.

Copy link
Owner

@fnielsen fnielsen commented Dec 4, 2019

I am wondering whether HTML base tag could/should be used (too)

@Daniel-Mietchen

This comment has been minimized.

Copy link
Collaborator Author

@Daniel-Mietchen Daniel-Mietchen commented Dec 5, 2019

Users are beginning to notice: https://twitter.com/GerardMeijssen/status/1202466066175266816

@fnielsen

This comment has been minimized.

Copy link
Owner

@fnielsen fnielsen commented Dec 5, 2019

The favicon is now running.

I had difficulty reviewing the code as I am not familiar with favicon. I thought it was just a question of putting something in the root directory, but I see it is somewhat more elaborate.

@carlinmack

This comment has been minimized.

Copy link
Contributor

@carlinmack carlinmack commented Dec 5, 2019

Need to add a few more redirects but for 99% of real use cases it's fine :)

@carlinmack

This comment has been minimized.

Copy link
Contributor

@carlinmack carlinmack commented Dec 5, 2019

Actually reading what that says, I don't know if we can fully resolve as we aren't serving our site from the / root domain. Therefore I don't think there is much that can be done but that's not a bad thing :)

@Daniel-Mietchen

This comment has been minimized.

Copy link
Collaborator Author

@Daniel-Mietchen Daniel-Mietchen commented Dec 7, 2019

Looks good enough for the moment. Close?

@carlinmack

This comment has been minimized.

Copy link
Contributor

@carlinmack carlinmack commented Dec 7, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.