Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: EoN (Epidemics on Networks), software for simulation, analytic approximation, and analysis of epidemics on networks #1731
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @acolum, @pholme it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Just finished my review - everything looks great! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
OK, @hagberg is now a reviewer |
This comment has been minimized.
This comment has been minimized.
@hagberg how is the review going? |
This comment has been minimized.
This comment has been minimized.
Hi @hagberg, did you end up opening the issues to ask the authors to change issues you saw during the review? If yes, can you link them here? Thanks! |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1731 with the following error: Error reading bibliography ./paper.bib (line 39, column 1): |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @lpantano - Do you know if there is any way to embed a video into the pdf file? One of the final things I want to show is a tool to build an animation, but at present I can't find any way to embed it. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks good. Issues are closed. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@joelmiller, it seems there are missing DOIs, can you double check this? Thanks! |
This comment has been minimized.
This comment has been minimized.
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@lpantano - I think this is good to go now. I've updated the references and gone through the paper a couple times. |
This comment has been minimized.
This comment has been minimized.
thank you! Last step is to create a Zenodo archive: The title needs to be the same than in the paper, together with the authors. When you are ready you can paste here the Zenodo link. Thanks! |
This comment has been minimized.
This comment has been minimized.
That's actually a bit problematic. The software was developed initially alongside a textbook I was writing, so it sits within https://github.com/springer-math (which I don't own). I've sent a request to give Zenodo the necessary access. But the editor who set up that site has left the company, and I'm not even sure that anyone will get the message. It looks like it hasn't been used since he left (over a year ago). Thoughts? The obvious idea would be to create a new repository. But I prefer to move things around as little as possible. |
This comment has been minimized.
This comment has been minimized.
You can simply tar the repo and manually deposit it in Zenodo (or figshare, or any other archival repository that will accept it and provide a DOI) This is what the GitHub - Zenodo link automates, but you don't have to use the automatic mechanism |
whedon commentedSep 15, 2019
•
edited by hagberg
Submitting author: @joelmiller (Joel Miller)
Repository: https://github.com/springer-math/Mathematics-of-Epidemics-on-Networks
Version: v1.0.8
Editor: @lpantano
Reviewers: @acolum, @pholme, @hagberg
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@acolum & @pholme, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lpantano know.
Review checklist for @acolum
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @pholme
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @hagberg
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper