Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should rio return tibbles by default? #197

Closed
leeper opened this issue Jan 12, 2019 · 2 comments
Closed

Should rio return tibbles by default? #197

leeper opened this issue Jan 12, 2019 · 2 comments
Labels

Comments

@leeper
Copy link
Owner

@leeper leeper commented Jan 12, 2019

Please specify whether your issue is about:

  • a suggested code or documentation change, improvement to the code, or feature request

We've been returning data frames given that tibbles were (and have been) pretty unstable. Worth revisiting making tibbles the default output?

@nathancday

This comment has been minimized.

Copy link
Contributor

@nathancday nathancday commented Feb 26, 2019

Just for awareness the new .name_repair requirements/methods seem to be in flux tidyverse/tibble#566 This is a pain point for an un-named columns that are being returned

@billdenney

This comment has been minimized.

Copy link
Contributor

@billdenney billdenney commented Dec 17, 2019

I'd prefer not.

With name repair, column names can be changed in ways that are not necessarily obvious to the user. And, when I receive ugly data (sometimes with duplicate or NA names), tibbles will intentionally error. I'd prefer to simply allow the user to use as_tibble() after the load, if that is what they want.

(For reference, I use tibbles a lot, but I prefer having the option.)

@leeper leeper removed this from the v0.6 milestone Dec 20, 2019
@leeper leeper closed this Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.