[REVIEW]: 3D reconstruction toolbox for behavior tracked with multiple cameras #1849

whedon · 2019-10-30T11:53:45Z

Submitting author: @SwathiSheshadri (Swathi Sheshadri)
Repository: https://github.com/SwathiSheshadri/pose3d
Version: v2.2.1
Editor: @cMadan
Reviewer: @danasolav, @sreschechtko
Archive: 10.5281/zenodo.3589990

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8e825866efe9a51e8f095d20bf99fd60"><img src="https://joss.theoj.org/papers/8e825866efe9a51e8f095d20bf99fd60/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8e825866efe9a51e8f095d20bf99fd60/status.svg)](https://joss.theoj.org/papers/8e825866efe9a51e8f095d20bf99fd60)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@danasolav & @sreschechtko, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @cMadan know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @danasolav

Conflict of interest

I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

I confirm that I read and will adhere to the JOSS code of conduct.

General checks

Repository: Is the source code for this software available at the repository url?
License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
Contribution and authorship: Has the submitting author (@SwathiSheshadri) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

Installation: Does installation proceed as outlined in the documentation?
Functionality: Have the functional claims of the software been confirmed?
Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
State of the field: Do the authors describe how this software compares to other commonly-used packages?
Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @sreschechtko

Conflict of interest

I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

I confirm that I read and will adhere to the JOSS code of conduct.

General checks

Repository: Is the source code for this software available at the repository url?
License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
Contribution and authorship: Has the submitting author (@SwathiSheshadri) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

Installation: Does installation proceed as outlined in the documentation?
Functionality: Have the functional claims of the software been confirmed?
Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
State of the field: Do the authors describe how this software compares to other commonly-used packages?
Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

whedon · 2019-10-30T11:53:48Z

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @danasolav, @sreschechtko it looks like you're currently assigned to review this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

whedon · 2019-10-30T11:53:48Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2019-10-30T11:54:37Z

👉 Check article proof 📄 👈

SwathiSheshadri · 2019-10-30T21:57:07Z

@danasolav, @sreschechtko thank you for taking time to review our submission.
@cMadan, please assign the latest release version v1.1.0 for review.

cMadan · 2019-10-30T22:44:46Z

@whedon set v1.1.0 as version

whedon · 2019-10-30T22:44:50Z

OK. v1.1.0 is the version.

sreschechtko · 2019-11-18T15:44:34Z

I was able to install the package and run the demo as well as my own data. I have raised some issues (#1-6) which I ran into during this process and which I would like to see addressed before recommending the publication of this package in JOSS.

cMadan · 2019-11-19T01:46:39Z

@sreschechtko, thank you for the update!

SwathiSheshadri · 2019-11-21T16:55:51Z

Thank you very much @sreschechtko for your time as well as for giving us detailed and very constructive review comments. We are very happy to hear that the code ran for you for the demo as well as for your own data. We will work on the issues you have raised at the repository and write back to you here.

danasolav · 2019-12-02T16:04:12Z

I have installed and ran the demo successfully. I would like to run my own data which was not acquired using DLC. Therefore I have raised an issue (#7) regarding the instructions for creating the csv file which is used as input.

SwathiSheshadri · 2019-12-03T11:55:35Z

@sreschechtko, please see our responses on the issues you raised at pose3d (#1-6). We have addressed the issues and have updated the repository to reflect the changes. Please use the latest release of pose3d v2.0.0 to see the changes done to pose3d as per your comments. We found your feedback and detailed comments very helpful for us in refining our repository for public use and we thank you very much again for your time and effort and look forward to hearing from you!

SwathiSheshadri · 2019-12-03T12:04:58Z

@danasolav, we developed pose3d using our 2D tracked data from DLC and we are very happy to hear that you have 2D tracked data outside of DLC framework as this will help us get your perspective on our code for this particular use-case. In our latest release of pose3d (v2.0.0), we have updated the readme file (addressing issue #7) to include details on preparing the .csv files required for pose3d when using a different software for 2D tracking. Looking forward to hearing more about your experience with pose3d!

sreschechtko · 2019-12-09T16:16:30Z

Thank you for responding to my review issues. I have closed the majority of issues because I think they are satisfactorily addressed, although I had a few minor comments on 5 and 7.

The only issue I raised which I am leaving open is 3 for plotting 2D data with the 3D reconstruction. I think pose3d should have the option to plot the 2d points (which it already has access to) on an un-annotated video since annotated video is not necessarily commonly saved output. I would also like to a see more descriptive error message in the plotter if the video is not available but the option to plot it has been selected.

SwathiSheshadri · 2019-12-11T20:11:59Z

Thank you for closing the issues @sreschechtko
I have addressed the open issue #3 as well as the minor comments in the latest release of pose3d (v2.1.1).
The plotting function has been updated to allow feature annotation along with plotting video frames/images used for 2D tracking recorded from primary camera. Alternatively, make_illustrative_movie.m helper function is now updated to allow users to flexibly select from any number of perspectives they want to visualize alongside 3D reconstructed results. Furthermore, error handling in the config file has been upgraded to deal with missing video/image path entries in the config file. I have also removed the requirement of user input for frame rate and duration of recording parameters in the config file to make editing the config file easier, thereby, less error prone.
I again thank you both (@danasolav and @sreschechtko) for your time and very helpful feedback and would be very happy to hear back from you.

sreschechtko · 2019-12-21T01:38:27Z

Hi All, I have closed all of the issues I opened on the main repository and am happy to recommend the package/article for publication in JOSS.

SwathiSheshadri · 2019-12-21T12:07:09Z

Thank you for closing all the issues @danasolav and @sreschechtko. Your feedback was immensely valuable towards making pose3d better for public use and we are very grateful to both of you for your time and effort! @cMadan, we are very thankful to you and the JOSS team for taking time to edit our submission. We request you to use the latest release of pose3d - version v2.2.1, archived with following DOI at Zenodo 10.5281/zenodo.3589990 , for further processing at JOSS and look forward to hearing from you about the next steps to take for our submission!

cMadan · 2019-12-25T01:41:20Z

Thank you for the thorough reviews, @danasolav and @sreschechtko!

cMadan · 2019-12-25T01:41:34Z

@whedon set v2.2.1 as version

whedon · 2019-12-25T01:41:38Z

OK. v2.2.1 is the version.

cMadan · 2019-12-25T01:42:02Z

@whedon set 10.5281/zenodo.3589990 as archive

whedon · 2019-12-25T01:42:06Z

OK. 10.5281/zenodo.3589990 is the archive.

cMadan · 2019-12-25T01:43:57Z

@SwathiSheshadri, please revise the archive name in Zenodo to match the name of your submission.

cMadan · 2019-12-25T05:25:42Z

@whedon check references

whedon · 2019-12-25T05:25:45Z

Attempting to check references...

whedon · 2019-12-25T05:26:25Z


OK DOIs

- 10.1038/s41593-018-0209-y is OK
- 10.1038/s41596-019-0176-0 is OK
- 10.1109/CVPR.2016.90 is OK
- 10.1109/CVPR.2009.5206848 is OK
- 10.5281/zenodo.3364758 is OK

MISSING DOIs

- None

INVALID DOIs

- None

cMadan · 2019-12-25T22:53:03Z

@SwathiSheshadri, I'm not sure why that isn't working, but will look into it.

@openjournals/joss-eics, it looks like the archive link in the compiled PDF isn't working. Any ideas why (or how we might otherwise resolve this)?

Kevin-Mattheus-Moerman · 2019-12-26T08:30:28Z

@cMadan

@openjournals/joss-eics, it looks like the archive link in the compiled PDF isn't working. Any ideas why (or how we might otherwise resolve this)?

Those links should be fixed in the final accepted version. Some automatically generated links are not active in these proofs (all author generated links should work though).
FYI in the future you can also address @openjournals/dev for technical support

SwathiSheshadri · 2019-12-26T08:47:44Z

@cMadan and @Kevin-Mattheus-Moerman, thank you for your quick responses! I have checked that the other links in the document are working fine.

arfon · 2019-12-29T13:00:40Z

@openjournals/joss-eics, it looks like the archive link in the compiled PDF isn't working. Any ideas why (or how we might otherwise resolve this)?

Yeah, sorry about this. That's undocumented behaviour and very confusing...

arfon · 2019-12-29T13:00:44Z

@whedon accept

whedon · 2019-12-29T13:00:47Z

Attempting dry run of processing paper acceptance...

arfon · 2019-12-29T13:01:19Z

@cMadan - as an editor you are able to ask Whedon to make final proofs of the PDF with @whedon accept and these PDFs should have working links.

whedon · 2019-12-29T13:02:20Z


OK DOIs

- 10.1038/s41593-018-0209-y is OK
- 10.1038/s41596-019-0176-0 is OK
- 10.1109/CVPR.2016.90 is OK
- 10.1109/CVPR.2009.5206848 is OK
- 10.5281/zenodo.3364758 is OK

MISSING DOIs

- None

INVALID DOIs

- None

whedon · 2019-12-29T13:02:25Z

Check final proof 👉 openjournals/joss-papers#1202

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1202, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

danielskatz · 2020-01-06T14:37:47Z

@SwathiSheshadri - please fix the cases (upper vs lower) in the bib entries - use {}s to protect cases where needed.

danielskatz · 2020-01-06T14:38:17Z

@cMadan - Other than the case issue in the bib, is this otherwise ready to accept?

SwathiSheshadri · 2020-01-06T16:42:52Z

@whedon generate pdf

whedon · 2020-01-06T16:42:55Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2020-01-06T16:44:04Z

👉 Check article proof 📄 👈

SwathiSheshadri · 2020-01-06T16:51:25Z

@danielskatz, thank you for your response and input on the case issue in the .bib file. It is now updated.

danielskatz · 2020-01-07T16:11:10Z

@whedon accept

whedon · 2020-01-07T16:11:13Z

Attempting dry run of processing paper acceptance...

whedon · 2020-01-07T16:12:31Z

Reference check summary:

OK DOIs

- 10.1038/s41593-018-0209-y is OK
- 10.1038/s41596-019-0176-0 is OK
- 10.1109/CVPR.2016.90 is OK
- 10.1109/CVPR.2009.5206848 is OK
- 10.5281/zenodo.3364758 is OK

MISSING DOIs

- None

INVALID DOIs

- None

whedon · 2020-01-07T16:12:37Z

Check final proof 👉 openjournals/joss-papers#1207

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1207, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

danielskatz · 2020-01-07T16:13:33Z

👋 @arfon - note ref6 has the same incomplete URL problem...

danielskatz · 2020-01-07T16:13:46Z

@whedon accept deposit=true

whedon · 2020-01-07T16:13:50Z

Doing it live! Attempting automated processing of paper acceptance...

whedon · 2020-01-07T16:15:58Z

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon · 2020-01-07T16:15:59Z

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited 👉 openjournals/joss-papers#1208
Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01849
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

danielskatz · 2020-01-07T16:17:35Z

Thanks to @danasolav and @sreschechtko for reviewing!
And to @cMadan for editing!
And congratulations to @SwathiSheshadri and co-authors!

danielskatz · 2020-01-07T16:17:48Z

👋 @arfon - can you fix the XML (ref6), and then close this?

arfon · 2020-01-07T16:36:39Z

Fixed.

whedon · 2020-01-07T16:36:43Z

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.01849/status.svg)](https://doi.org/10.21105/joss.01849)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01849">
  <img src="https://joss.theoj.org/papers/10.21105/joss.01849/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.01849/status.svg
   :target: https://doi.org/10.21105/joss.01849

This is how it will look in your documentation:

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://joss.theoj.org/reviewer-signup.html
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

whedon added the review label Oct 30, 2019

whedon assigned cMadan Oct 30, 2019

whedon mentioned this issue Oct 30, 2019

[PRE REVIEW]: 3D reconstruction toolbox for behavior tracked with multiple cameras #1648

Closed

whedon assigned sreschechtko Oct 31, 2019

whedon assigned danasolav Dec 3, 2019

whedon added the accepted label Jan 7, 2020

arfon closed this Jan 7, 2020

Please note that GitHub no longer supports your web browser.

openjournals / joss-reviews

Sponsor openjournals/joss-reviews

Join GitHub today

[REVIEW]: 3D reconstruction toolbox for behavior tracked with multiple cameras #1849

[REVIEW]: 3D reconstruction toolbox for behavior tracked with multiple cameras #1849

Comments

whedon commented Oct 30, 2019 • edited

Status

Reviewer instructions & questions

Review checklist for @danasolav

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @sreschechtko

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

This comment has been minimized.

whedon commented Oct 30, 2019

This comment has been minimized.

whedon commented Oct 30, 2019

This comment has been minimized.

whedon commented Oct 30, 2019

This comment has been minimized.

SwathiSheshadri commented Oct 30, 2019

This comment has been minimized.

cMadan commented Oct 30, 2019

This comment has been minimized.

whedon commented Oct 30, 2019

This comment has been minimized.

sreschechtko commented Nov 18, 2019

This comment has been minimized.

cMadan commented Nov 19, 2019

This comment has been minimized.

SwathiSheshadri commented Nov 21, 2019

This comment has been minimized.

danasolav commented Dec 2, 2019

This comment has been minimized.

SwathiSheshadri commented Dec 3, 2019

This comment has been minimized.

SwathiSheshadri commented Dec 3, 2019 • edited

This comment has been minimized.

sreschechtko commented Dec 9, 2019

This comment has been minimized.

SwathiSheshadri commented Dec 11, 2019 • edited

This comment has been minimized.

sreschechtko commented Dec 21, 2019

This comment has been minimized.

SwathiSheshadri commented Dec 21, 2019 • edited

This comment has been minimized.

cMadan commented Dec 25, 2019

This comment has been minimized.

cMadan commented Dec 25, 2019

This comment has been minimized.

whedon commented Dec 25, 2019

This comment has been minimized.

cMadan commented Dec 25, 2019

This comment has been minimized.

whedon commented Dec 25, 2019

This comment has been minimized.

cMadan commented Dec 25, 2019

This comment has been minimized.

cMadan commented Dec 25, 2019

This comment has been minimized.

whedon commented Dec 25, 2019

This comment has been minimized.

whedon commented Dec 25, 2019

This comment has been minimized.

cMadan commented Dec 25, 2019

This comment has been minimized.

Kevin-Mattheus-Moerman commented Dec 26, 2019 • edited

This comment has been minimized.

SwathiSheshadri commented Dec 26, 2019

whedon commented Oct 30, 2019 •

edited

SwathiSheshadri commented Dec 3, 2019 •

edited

SwathiSheshadri commented Dec 11, 2019 •

edited

SwathiSheshadri commented Dec 21, 2019 •

edited

Kevin-Mattheus-Moerman commented Dec 26, 2019 •

edited