adam3smith / dataverse-client-r

fix multi-download for datasets with folders and change logic

Fix handling of fq

Dev

from @leeper

ref IQSS#38

https://style.tidyverse.org/tests.html#organisation-1

ref IQSS#4

ref IQSS#40

ref IQSS#40

ref IQSS#40

ref IQSS#44

ref IQSS#38

https://demo.dataverse.org/dataverse/dataverse-client-r

ref IQSS#40

This interferes with all the assignments that happens within the function parameter defaults.  And also the tests.

ref IQSS#40

ref IQSS#40

ref IQSS#40

ref IQSS#40

ref IQSS#4

run in a new environment

ref IQSS#33

also correct `create_dataverse()`

ref IQSS#33

cc: @kuriwaki

ref IQSS#33

addressing 404 errors in vignette

also, remove date

ref IQSS#38

@leeper, I believe thesee are the correct modifications, according to [CRAN](https://journal.r-project.org/archive/2012/RJ-2012-009/RJ-2012-009.pdf) and [Hadley](http://r-pkgs.had.co.nz/description.html).  Tell me if you think I've misinterpreted something.

@pdurbin, please check your ORCID number.  I found it [here](https://dataverse.harvard.edu/dataset.xhtml?persistentId=doi:10.7910/DVN/TJCLKP)

ref IQSS#38

from 6.1.1

ref IQSS#38

ref IQSS#38

Currently fq is completely broken:
1. It requires start to be set for no reason
2. It fails because match.arg will always fail since no args are given in the function

This fix does three things:
1. Test for fq rather than start
2. get rid of the match.arg -- since fq is super flexible, we can't use that here
3. enclose the fq query in I to prevent URL encoding (see r-lib/httr#540 (comment) ). Otherwise, httr encodes colons, square brackets and + and e.g. the [example for date range search](http://guides.dataverse.org/en/latest/api/search.html#date-range-search-example) breaks