Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 more panels for topics #996

Merged
merged 2 commits into from Jan 13, 2020
Merged

3 more panels for topics #996

merged 2 commits into from Jan 13, 2020

Conversation

@Daniel-Mietchen
Copy link
Collaborator

Daniel-Mietchen commented Dec 14, 2019

Adds the following panels:

  • for the topic aspect:
    • a panel on Earliest published works on the topic
  • for the /missing page of the topic aspect:
    • a panel on missing publication dates
    • a panel on missing publication venues

<h2>Missing publication venue</h2>

For the listed publications, Wikidata does not have pa statement as to where they were published.

This comment has been minimized.

Copy link
@cthoyt

cthoyt Dec 16, 2019

Contributor

Is there a typo in "does not have pa statement"?

This comment has been minimized.

Copy link
@Daniel-Mietchen

Daniel-Mietchen Dec 16, 2019

Author Collaborator

Yes. Fixed.

@Daniel-Mietchen

This comment has been minimized.

Copy link
Collaborator Author

Daniel-Mietchen commented Jan 13, 2020

I just tested this again and think it's ripe for merging.

@Daniel-Mietchen Daniel-Mietchen merged commit 13e12e8 into master Jan 13, 2020
1 check passed
1 check passed
security/snyk - requirements.txt (fnielsen) No manifest changes detected
@Daniel-Mietchen Daniel-Mietchen deleted the feature-topic-enrichment branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.