Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: MyQueue: Task and workflow scheduling system #1844
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @gonsie, @marksantcroos it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
If you have any questions or problems, please let me know |
This comment has been minimized.
This comment has been minimized.
Thanks for submission @jjmortensen. I've created some issues in the repo: For the paper, could you include some details on how MyQueue compares with other tools? I think the most relevant tools would come from the workflow tools / managers. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@jjmortensen - fwiw, a long list of workflow tools is in https://github.com/common-workflow-language/common-workflow-language/wiki/Existing-Workflow-systems (and a shorter list is in https://github.com/meirwah/awesome-workflow-engines) |
This comment has been minimized.
This comment has been minimized.
Thanks for the links. I'm familiar with Fireworks and Aiida. Will take a look ... |
This comment has been minimized.
This comment has been minimized.
I've also started my review by going through installation and testing, but got stuck rather quickly.
Although I might be biased, these errors do trigger my "yet another workflow system that tries (and fails) to integrate with queuing systems". Putting this out here for now, will continue the review and edit accordingly. |
This comment has been minimized.
This comment has been minimized.
Thanks for all your comments so far. There is now a version 19.11.1 available on PyPI with some new features and bug-fixes. There is also an updated version of the paper. See: https://myqueue.readthedocs.io/en/latest/releasenotes.html |
This comment has been minimized.
This comment has been minimized.
When you update the paper, please rebuild it here (using the following whedon command), as I am now going to do |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This paper is still missing a ‘state of the field’ summary. Comparing MQ to Slurm/PBS is not the right level of comparison. It needs to be compared to other workflow tools. In addition, the paper mentions that MQ was used to drive a study of 10,000 jobs. Please provide details on that. How did it handle this large number of jobs? What was the job limit enforced by the underlying scheduler? I believe that this may be the real contribution of MQ (rather than just a front end to a scheduler). |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
We are looking into it ... in the meantime, @gonsie I added a small section on the web-page describing how to work with many jobs: https://myqueue.readthedocs.io/en/latest/workflows.html#handling-very-many-tasks |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We have now added a section describing the state of the field, where we compare MyQueue to AiiDA and Fireworks, trying to emphasize what MyQueue can/cannot do. Let us know if you have suggestions for further improvements. |
This comment has been minimized.
This comment has been minimized.
I've worked some more with the software and got something out of it. Will go over the new pdf and report my findings. |
This comment has been minimized.
This comment has been minimized.
@marksantcroos - thanks |
This comment has been minimized.
This comment has been minimized.
@marksantcroos - any update? |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Added the missing DOI and upper cased JSSPP |
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
No archive DOI set. Exiting... |
This comment has been minimized.
This comment has been minimized.
At this point could you:
I can then move forward with accepting the submission. |
This comment has been minimized.
This comment has been minimized.
The MyQueue version is 20.1.1 and the tag name in the Git repository is "version-20.1.1":
I've uploaded an archive to Zenodo:
The DOI is "10.5281/zenodo.3607221". |
This comment has been minimized.
This comment has been minimized.
@whedon set version-20.1.1 as version |
This comment has been minimized.
This comment has been minimized.
OK. version-20.1.1 is the version. |
This comment has been minimized.
This comment has been minimized.
@whedon set 10.5281/zenodo.3607221 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.3607221 is the archive. |
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1214, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1215, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
@whedon accept deposit=true |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
Thanks to @gonsie, @marksantcroos for reviewing! |
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
whedon commentedOct 29, 2019
•
edited
Submitting author: @jjmortensen (Jens Jørgen Mortensen)
Repository: https://gitlab.com/myqueue/myqueue
Version: version-20.1.1
Editor: @danielskatz
Reviewer: @gonsie, @marksantcroos
Archive: 10.5281/zenodo.3607221
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gonsie & @marksantcroos, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
Review checklist for @gonsie
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @marksantcroos
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper