Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: PyMarket #1591
[REVIEW]: PyMarket #1591
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @igarizio, @taqtiqa-mark it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hello, Do you have anything so far that you would like me to fix or clarify? Best regards, |
This comment has been minimized.
This comment has been minimized.
Hello @gus0k Here are some of my comments:
I will continue to review the other items in the checklist and will post if necessary. Please let me know if you have any questions. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon set v0.7.5 as version |
This comment has been minimized.
This comment has been minimized.
I'm sorry @gus0k, I'm afraid I can't do that. That's something only editors are allowed to do. |
This comment has been minimized.
This comment has been minimized.
@igarizio @taqtiqa-mark Thank you both so far for your input. I have updated the paper to list the implemented algorithms and their references. @alexhanna Would it be possible to update the version number to 0.7.5? Regarding the acknowledgements, Telecom ParisTech is paying for my PhD. In that sense, I feel it plays the same role as funding entities. Best regards, |
This comment has been minimized.
This comment has been minimized.
@igarizio @taqtiqa-mark , can I help you in any way to advance in your reviews? |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon set v0.7.5 as version |
This comment has been minimized.
This comment has been minimized.
OK. v0.7.5 is the version. |
This comment has been minimized.
This comment has been minimized.
@gus0k the version has been updated. |
This comment has been minimized.
This comment has been minimized.
Thank you. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hello, What is the status on this? Best regards, |
This comment has been minimized.
This comment has been minimized.
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sorry, missed one in the bib - please merge gus0k/pymarket#20 as well |
This comment has been minimized.
This comment has been minimized.
also, be aware that you can do |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@danielskatz 10.5281/zenodo.3665175 |
This comment has been minimized.
This comment has been minimized.
@whedon set v0.7.8 as version |
This comment has been minimized.
This comment has been minimized.
OK. v0.7.8 is the version. |
This comment has been minimized.
This comment has been minimized.
@whedon set 10.5281/zenodo.3665175 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.3665175 is the archive. |
This comment has been minimized.
This comment has been minimized.
Please change the metadata in the zenodo repository so that the title is the same as the title of the paper |
This comment has been minimized.
This comment has been minimized.
Done |
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1299, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
@whedon accept deposit=true |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
Thanks to @igarizio & @taqtiqa-mark for reviewing! Congratulations to @gus0k and co-authors! |
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
This comment has been minimized.
This comment has been minimized.
Thank you all! |
whedon commentedJul 23, 2019
•
edited
Submitting author: @gus0k (Diego)
Repository: https://github.com/gus0k/pymarket
Version: v0.7.8
Editor: @alexhanna
Reviewer: @igarizio, @taqtiqa-mark
Archive: 10.5281/zenodo.3665175
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@igarizio & @taqtiqa-mark, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @alexhanna know.
Review checklist for @igarizio
Conflict of interest
Code of Conduct
General checks
Functionality
gus0k/pymarket/issues/13Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @taqtiqa-mark
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
gus0k/pymarket/issues/3Software paper
paper.md
file include a list of authors with their affiliations?gus0k/pymarket/issues/3gus0k/pymarket/issues/2