Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: CarrierCapture.jl: Anharmonic Carrier Capture #2102
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @utf, @taylor-a-barnes it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Your job now is to examine the paper and the software, and to check off the items on your list that you can, and to explain what blocks you from checking off other items, either here if they are brief, or in new issues in the source repo if they are more complex. (If you do open issues in the source repo, please mention this review issue in those issues so that we can see them here as well.) We expect that the review will be done in a couple of weeks, at most, or at least it will get to a list of blocking items in that timeframe. |
whedon commentedFeb 13, 2020
Submitting author: @frssp (Sunghyun Kim)
Repository: https://github.com/WMD-group/CarrierCapture.jl
Version: v0.1
Editor: @danielskatz
Reviewer: @utf, @taylor-a-barnes
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@utf & @taylor-a-barnes, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
Review checklist for @utf
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @taylor-a-barnes
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper