Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: CarrierCapture.jl: Anharmonic Carrier Capture #2091

Closed
whedon opened this issue Feb 10, 2020 · 30 comments
Closed

[PRE REVIEW]: CarrierCapture.jl: Anharmonic Carrier Capture #2091

whedon opened this issue Feb 10, 2020 · 30 comments

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Feb 10, 2020

Submitting author: @frssp (Sunghyun Kim)
Repository: https://github.com/WMD-group/CarrierCapture.jl
Version: v0.1
Editor: @danielskatz
Reviewers: @utf, @taylor-a-barnes
Managing EiC: Daniel S. Katz

Author instructions

Thanks for submitting your paper to JOSS @frssp. Currently, there isn't an JOSS editor assigned to your paper.

@frssp if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Feb 10, 2020
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.09 s (441.2 files/s, 54128.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           16            284            112           1112
Markdown                         9            197              0            584
Python                           4             92             50            236
Jupyter Notebook                 4              0           1818            224
YAML                             5             15             29            179
TeX                              1              7              0             63
TOML                             2              1              0             27
-------------------------------------------------------------------------------
SUM:                            41            596           2009           2425
-------------------------------------------------------------------------------


Statistical information for the repository '2091' was gathered on 2020/02/10.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Sunghyun Kim                     4           101            234           35.19
frssp                            3           563             54           64.81

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Sungyun Kim                 378          100.0          9.6                8.20
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Reference check summary:

OK DOIs

- None

MISSING DOIs

- https://doi.org/10.1088/0034-4885/44/12/001 may be missing for title: Non-radiative transitions in semiconductors
- https://doi.org/10.1103/physrevb.90.075202 may be missing for title: First-principles theory of nonradiative carrier capture via multiphonon emission
- https://doi.org/10.1103/physrevb.100.041202 may be missing for title: Anharmonic lattice relaxation during nonradiative carrier capture

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 10, 2020

👋 @frssp - there seem to be some DOIs missing in your bib file - please add any that are correct (noting that whedon's reference check summary sometimes makes mistakes)

@frssp

This comment has been minimized.

Copy link

@frssp frssp commented Feb 11, 2020

Updated.
@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 11, 2020

PDF failed to compile for issue #2091 with the following error:

Error reading bibliography ./paper.bib (line 14, column 3):
unexpected "d"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@frssp

This comment has been minimized.

Copy link

@frssp frssp commented Feb 11, 2020

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 11, 2020

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 11, 2020

Thanks - one of the DOIs has a leading "https:/doi.org/" that should be removed

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 11, 2020

@whedon assign @danielskatz as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 11, 2020

OK, the editor is @danielskatz

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 11, 2020

If you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

@frssp

This comment has been minimized.

Copy link

@frssp frssp commented Feb 13, 2020

I suggest JMSkelton and utf for potential reviewers because they are experts in computational chemistry.

@frssp

This comment has been minimized.

Copy link

@frssp frssp commented Feb 13, 2020

DOI fixed; @whedon generate pdf

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 13, 2020

@whedon generate pdf has to be the start (or entirety) of a comment

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 13, 2020

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 13, 2020

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 13, 2020

👋 @JMSkelton & @utf - would either or both of you be willing to review this submission?

@utf

This comment has been minimized.

Copy link
Collaborator

@utf utf commented Feb 13, 2020

I’d be happy to review this.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 13, 2020

👋 @godotalgorithm & @taylor-a-barnes - would either or both of you be willing to review this submission to JOSS? JOSS reviews are of the software and short paper, and are checklist-driven, with the goal of improving the software to the point where it can be accepted - see https://joss.readthedocs.io/en/latest/reviewer_guidelines.html for more info

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 13, 2020

Thanks @utf - I'll assign you, but we won't start until we get at least one more reviewer.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 13, 2020

@whedon assign @utf as reviewer

@whedon whedon assigned danielskatz and unassigned danielskatz Feb 13, 2020
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 13, 2020

OK, @utf is now a reviewer

@taylor-a-barnes

This comment has been minimized.

Copy link

@taylor-a-barnes taylor-a-barnes commented Feb 13, 2020

@danielskatz I would be happy to review this submission.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 13, 2020

Thanks @taylor-a-barnes - I'll add you, and we'll start the review process in a new thread - hang on...

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 13, 2020

@whedon add @taylor-a-barnes as reviewer

@whedon whedon assigned danielskatz, taylor-a-barnes and utf and unassigned utf and danielskatz Feb 13, 2020
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 13, 2020

OK, @taylor-a-barnes is now a reviewer

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 13, 2020

@whedon start review

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 13, 2020

OK, I've started the review over in #2102.

@whedon whedon closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.