Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SyntenyViz #2068

Closed
whedon opened this issue Feb 4, 2020 · 9 comments
Closed

[PRE REVIEW]: SyntenyViz #2068

whedon opened this issue Feb 4, 2020 · 9 comments

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Feb 4, 2020

Submitting author: @robqiao (Robert QIAO)
Repository: https://github.com/DPP4ResearchGroup/SyntenyViz
Version: v0.0.0.9000
Editor: Pending
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @robqiao. Currently, there isn't an JOSS editor assigned to your paper.

@robqiao if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Feb 4, 2020
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 4, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 4, 2020

PDF failed to compile for issue #2068 with the following error:

Error reading bibliography ./paper.bib (line 2, column 1):
unexpected "}"
expecting space
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 4, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.04 s (787.4 files/s, 20145.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               21             48            324            224
Markdown                         2              4              0             32
Bourne Shell                     3             13             24             30
YAML                             1              0              0             22
Rmd                              1              2             12              5
TeX                              1              0              0              2
-------------------------------------------------------------------------------
SUM:                            29             67            360            315
-------------------------------------------------------------------------------


Statistical information for the repository '2068' was gathered on 2020/02/04.
No commited files with the specified extensions were found.
@whedon whedon added R Shell TeX labels Feb 4, 2020
@kthyng

This comment has been minimized.

Copy link

@kthyng kthyng commented Feb 4, 2020

Hi @robqiao! Thank you for your submission. Your submission is looking a bit unfinished currently because it lacks much of a readme, the vignette is empty, the paper looks like it wasn't finished, it's missing documentation, and therefore we at the editorial board as unsure how your package works and the type of input/output produced, and how to test it.

I suggest that you withdraw your submission, improve it, and resubmit in the future.

In case you want to do that, note that we are working to improve our guidelines for what counts as a "large enough" contribution to warrant a JOSS submission, but your current number of lines of code would raise a red flag for potentially being too small. Being a small package is not disqualifying, but it would require some extra explanation as to why it should still be enough to warrant a publication.

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 10, 2020

👋 @robqiao - as mentioned by @kthyng, I'm going to reject this as incomplete at this time. Normally, we would welcome a later submission of a more complete version, but given the small amount of code in your submission and the potential that it would be considered minor or a wrapper, you might want to first make a pre-submission inquiry, using https://github.com/openjournals/joss/issues/new?title=Pre-submission%20enquiry

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 10, 2020

@whedon reject

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Paper rejected.

@robqiao

This comment has been minimized.

Copy link

@robqiao robqiao commented Feb 13, 2020

Thx for your comments @danielskatz @kthyng
I forgot to merge the branch, now released.
plus what's the size deemed reasonable? do we have a whedon function to check? Many Thanks

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Feb 13, 2020

Can we discuss this in a pre-submission inquiry, using https://github.com/openjournals/joss/issues/new?title=Pre-submission%20enquiry
rather than a closed pre-review issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.