Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: MatSurv: Survival analysis and visualization in MATLAB #1830
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @dsurujon, @ManuelaS it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1830 with the following error: /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/lib/whedon.rb:135:in |
This comment has been minimized.
This comment has been minimized.
@jhcreed, can you please fix your paper.md? It looks like it's missing the date information. |
This comment has been minimized.
This comment has been minimized.
Sorry! I have added the date and double checked that it should compile. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@jhcreed, skimming your paper I found quite a few typos ("long", "calues", and a few others). Can you and your co-authors take a closer look at the text? |
This comment has been minimized.
This comment has been minimized.
We have looked back over it and fixed the typos. Thanks! |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thank you for this opportunity to review MatSurv. I have gone through the manuscript, documentation and example usage cases. I believe this is a very useful piece of code, and works well, with plenty of options for customization of the output figures. The authors have supplied a number of reproducible examples that are very helpful as well. However, I believe the authors can better highlight the utility of MatSurv by addressing the points I raise below. Once these are addressed, I will be happy to recommend the manuscript for publication. General checksAuthorship DocumentationStatement of need Community guidelines Software paperStatement of need Quality of writing
References
Other comments
Minor comments
|
This comment has been minimized.
This comment has been minimized.
@dsurujon, thank you for the thorough review! |
This comment has been minimized.
This comment has been minimized.
@ManuelaS, it would be great if you could begin your review soon, thanks! |
This comment has been minimized.
This comment has been minimized.
Thanks for the reminder @cMadan, I'll work through the review during the weekend! |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Hello all, We have made the changes to MatSurv and the Documentation as suggested by @dsurujon and we are waiting for the second reviewer comments so we can finalize our edits of the article. |
This comment has been minimized.
This comment has been minimized.
Apologies for the delay. I'll get to this in the next few days. |
This comment has been minimized.
This comment has been minimized.
Review Below some suggestions:
Minor comments:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Please confirm here when you have addressed the actions and are ready to proceed. |
This comment has been minimized.
This comment has been minimized.
The text and figure have been updated and we are ready to proceed. Thank you! |
This comment has been minimized.
This comment has been minimized.
Can you reduce the size of the figures very sightly - right now, they are slightly bigger than the page (they overlap the page footer). I'm also confused by the "(MATLAB 2019B)" in the text, which doesn't seem to match anything in the reference list. Similarly, Freireich 1963 and Ley 2013. Looking at the .md, this turns out to be because you are doing the references manually - please see the JOSS example paper and bib file and adjust your paper to correctly refer to the bib file entries - you will need to add these three additional papers to the bib file as well. Then again let me know when you think you are ready to proceed. |
This comment has been minimized.
This comment has been minimized.
The figure has been reduced so that it now fits on one page without running into the footer. We have also changed "(MATLAB 2019B)" to "[as of version MATLAB 2019B]" to clarify that we are specifying a version of software and not a reference. All of the references have been updated in the .md and .bib. We are ready to try to proceed again. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It still seems like Matlab 2019b should be a reference that should be in the .bib file and in the .md file, otherwise, the "MATLAB 2019B" doesn't refer to anything that the reader can find. |
This comment has been minimized.
This comment has been minimized.
the first reference also needs to be fix for the first author's name |
This comment has been minimized.
This comment has been minimized.
please make changes, use |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
No edits from me |
This comment has been minimized.
This comment has been minimized.
We are ready to try again! |
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1301, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
@whedon accept deposit=true |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks everyone! |
This comment has been minimized.
This comment has been minimized.
Thanks. I've fixed this now. |
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
whedon commentedOct 23, 2019
•
edited
Submitting author: @jhcreed (Jordan Creed)
Repository: https://github.com/aebergl/MatSurv
Version: v1.1.0
Editor: @cMadan
Reviewer: @dsurujon, @ManuelaS
Archive: 10.5281/zenodo.3632122
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@dsurujon & @ManuelaS, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @cMadan know.
Review checklist for @dsurujon
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @ManuelaS
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper