Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: ggalluvial: Layered Grammar for Alluvial Plots #1937
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @akeshavan it looks like you're currently assigned as the editor for this paper For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Failed to discover a valid open source license. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Also, please check to see if the missing DOI whedon suggests is correct, and if so, add it to the .bib file. (Whedon suggestions are just suggestions, and sometimes they are wrong.) |
This comment has been minimized.
This comment has been minimized.
@danielskatz thank you! I've added the missing DOI. To be sure, is it good practice to simply put the standard GPLv3 license text (file name |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yes, and if there are any deviations, you have changed the license to a non-OSI-approved one, which would mean that JOSS would not consider the submission. |
This comment has been minimized.
This comment has been minimized.
Right, thank you for pointing that out. In a moment i'll push the Markdown GPLv3 obtained from here, renamed |
This comment has been minimized.
This comment has been minimized.
not LICENSE.md but LICENSE |
This comment has been minimized.
This comment has been minimized.
Thank you, this has been changed (using the plain text version of GPLv3). |
This comment has been minimized.
This comment has been minimized.
From the list of potential reviewers, @kellieotto, @njtierney, and @clauswilke seem to have very relevant expertise and interests. |
This comment has been minimized.
This comment has been minimized.
Happy to provide a review, when would you like it completed? The end of the year is looming and I'm not sure if I could get it completed before December 20, but can try. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
hi @danielskatz , sorry I only just saw this! happy to review. @njtierney no worries, I know everyone is busy during the holidays! Can we plan for sometime in January? |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
I can do a review. Please send a reminder in early Jan. if I haven't done it by then. |
This comment has been minimized.
This comment has been minimized.
Hello! Sorry I haven't managed this yet, I am aiming for the end of Jan, if that is alright? |
This comment has been minimized.
This comment has been minimized.
Thank you all! @akeshavan is there anything i need to do before the review begins? (I have made some slight edits to the paper.) @whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @corybrunson - whedon commands have to be the start of a comment, like the following |
This comment has been minimized.
This comment has been minimized.
ah, you also figured this out - never mind... |
whedon commentedDec 6, 2019
Submitting author: @corybrunson (Jason Cory Brunson)
Repository: https://github.com/corybrunson/ggalluvial
Version: v0.11.1
Editor: @akeshavan
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @corybrunson. The JOSS editor @akeshavan, will work with you on this issue to find a reviewer for your submission before creating the main review issue.
@corybrunson if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: