Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upadding ABNF section #24
Conversation
This comment has been minimized.
This comment has been minimized.
@jscancella can you provide some rationale and background for this PR so that folks reviewing and providing feedback can be better informed? |
This comment has been minimized.
This comment has been minimized.
@ruebot sure! I think it is also just another way to communicate the specification and make sure there is no ambiguity in the specification that can cause problems later (like what happened in the BagIt specification). |
profile-description = DQUOTE "External-Description" DQUOTE ":" value "," | ||
profile-version = DQUOTE "Version" DQUOTE ":" version "," | ||
version = DQUOTE 1*DIGIT "." 1*DIGIT DQUOTE | ||
bag-info = DQUOTE "Bagit-Info" DQUOTE ":{" info-organization info-address info-name info-phone info-email info-description info-identifier info-size info-group-identifier info-count info-sender-identifier info-sender-description info-date info-payload-oxum "}," |
This comment has been minimized.
This comment has been minimized.
tdilauro
Dec 18, 2019
Member
The BagIt Profiles spec does not limit the tags that may be specified in the Bag-Info section, specifically noting support for arbitrary tags, including tags not enumerated in the BagIt spec.
email-address = DQUOTE addr-spec DQUOTE | ||
profile-description = DQUOTE "External-Description" DQUOTE ":" value "," | ||
profile-version = DQUOTE "Version" DQUOTE ":" version "," | ||
version = DQUOTE 1*DIGIT "." 1*DIGIT DQUOTE |
This comment has been minimized.
This comment has been minimized.
tdilauro
Dec 18, 2019
•
Member
version
rule supports multiple other rules with varying numbers of dots in their version numbers. A more generalized version production would be. Might considering calling it "dotted-version" to allow for more generalized (undotted) version strings in the future.
version = DQUOTE 1*DIGIT *("." 1*DIGIT) DQUOTE
or
dotted-version = DQUOTE 1*DIGIT *("." 1*DIGIT) DQUOTE
@jscancella I have some general concerns about
I’m away on vacation through the end of the year, but will try to find a chunk of time before the new year to dig deep enough to make these concerns a little less vague. |
This comment has been minimized.
This comment has been minimized.
@tdilauro I will also be gone most of January and unable to work on this until I get back. Hopefully I can finish it before I leave.
|
This comment has been minimized.
This comment has been minimized.
@jscancella Ugh. I just wanted to get my vague concerns out there, but didn't mean to cause any undo stress. I'll try to have a look sooner rather than later, but have to balance family vacation time. If it doesn't work out, we can always iterate later.
|
This comment has been minimized.
This comment has been minimized.
Don't worry about it, family is more important especially this time of year. Look at it when you get a chance, but don't stress. |
This comment has been minimized.
This comment has been minimized.
BagIt touches on the challenges here. Basically says it depends on the file system. But, JSON is case sensitive. Since a BagIt Profile is JSON, then a BagIt Profile is case sensitive, right? |
This comment has been minimized.
This comment has been minimized.
Maybe it didn't make it into the specification, but I remember talking about https://tools.ietf.org/html/rfc8493#section-6.1.1.1 with Chris Adams and how we should try and preserve case, but not force anyone to be case sensitive when looking up information. I looked at https://tools.ietf.org/html/rfc7159 but couldn't find where it says that |
This comment has been minimized.
This comment has been minimized.
Also I just found in ECMA-404
Perhaps I am not understanding, but from the wording above it seems it is up to the individual parsers to determine if the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I think that's fine, but we should be explicit about it. Additionally, the current release of the validator and my recently committed PR are case sensitive. |
@@ -58,7 +58,7 @@ <h1>Introduction</h1> | |||
<p> | |||
<pre> | |||
|
|||
BagIt Profile JSON file |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@jscancella @tdilauro do we need to create a separate issue for the case sensitivity, or should we just address it in this PR? Once we sort that out, we can create an issue for the validator. |
This comment has been minimized.
This comment has been minimized.
Unless I am misunderstanding I think it is resolved - make it case insensitive. I haven't seen any proposed updates on the forum for this either, so should we go ahead and merge it? |
This comment has been minimized.
This comment has been minimized.
@jscancella if you resolve the conflict, I'm happy to hit approve if everything looks good. Then you're welcome to merge and write your own commit message. |
This comment has been minimized.
This comment has been minimized.
The latest validator is case sensitive. Shouldn't these be in sync? |
This comment has been minimized.
This comment has been minimized.
@tdilauro yeah, ideally they should be in sync. If either you have time, feel free to go for it. Otherwise, it might be a bit before I can get to it. I'll create an issue over on the validator repo. |
jscancella commentedDec 16, 2019
This Pull Request integrates #23 into the index.html.