Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorldCat: Constant fallback from WorldCat Discovery Service to Open WorldCat #2066

Open
dstillman opened this issue Nov 23, 2019 · 5 comments

Comments

@dstillman
Copy link
Member

@dstillman dstillman commented Nov 23, 2019

https://forums.zotero.org/discussion/80185/erreur-lors-delenregistrement-avec-worldcat

This seems to be happening pretty consistently on worldcat.org. I'm not sure of the difference between WDS and OW, but it'd be nice to avoid the error message.

@zuphilip

This comment has been minimized.

Copy link
Collaborator

@zuphilip zuphilip commented Nov 25, 2019

Do you have an example URL for this? - I tested our test cases https://sbts.on.worldcat.org/oclc/667874424 and https://sbts.on.worldcat.org/oclc/795005226 which both seem to work okay for me.

@dstillman

This comment has been minimized.

@zuphilip

This comment has been minimized.

Copy link
Collaborator

@zuphilip zuphilip commented Nov 26, 2019

Okay, for that URL I see the Open World Cat as the top translator which then also works fine. But I also see WorldCat Discovery Services as another translator (with the same priority 100) which will lead to an error. On such a page the WorldCat Discovery Service translator should not be available, because it is not working.

The problem occurs because the value of extracted database ID which is needed for creating the RIS URL is null:

return ZU.xpathText(doc, '//input[@id="dbList"]/@value');

Thus, we can simply test for the presence of an element with id dbList in the detectWeb as well, to avoid that this translator is offered, in cases when it is not working. But maybe @adam3smith has other ideas or experiences with this issue.

@dstillman

This comment has been minimized.

Copy link
Member Author

@dstillman dstillman commented Nov 26, 2019

Oh, yeah, I get WDS first. Since they're both 100, it's probably nondeterministic.

@adam3smith

This comment has been minimized.

Copy link
Collaborator

@adam3smith adam3smith commented Nov 26, 2019

(I had never seen this before it was reported, so no other ideas, no; the proposed solution sounds good)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.