Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default for metadata #7

Open
michaelwitting opened this issue Apr 21, 2020 · 2 comments
Open

Default for metadata #7

michaelwitting opened this issue Apr 21, 2020 · 2 comments

Comments

@michaelwitting
Copy link
Owner

@michaelwitting michaelwitting commented Apr 21, 2020

Shall the metadata be read by default or not?
Ideas @jorainer, @sneumann, @schymane?

@schymane

This comment has been minimized.

Copy link

@schymane schymane commented Apr 21, 2020

I implemented a function in ReSOLUTION that by default took a select (relatively common) set of metadata, and left users the option to define other fields if desired ... that may be the way around this ...

https://github.com/schymane/ReSOLUTION/blob/master/R/MassBankRecordeR.R

https://github.com/schymane/ReSOLUTION/blob/master/R/MassBankRecordeR.R#L66

@michaelwitting

This comment has been minimized.

Copy link
Owner Author

@michaelwitting michaelwitting commented Apr 21, 2020

@schymane I like this idea. Currently, there is the option to define, which metadata blocks shall be read, e.g. all the analytical chemistry. In future by default all the entries you mentioned can be read and then the user can define which additional blocks he wants. I don't want to get the user to define it down to single entries, but I think blocks is okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.