Skip to content

/ JFoenix

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK 12 incompatible #955

Open
chengenzhao opened this issue Mar 20, 2019 · 20 comments
Open

JDK 12 incompatible #955

chengenzhao opened this issue Mar 20, 2019 · 20 comments
Labels
JDK 12 Type: Bug Version: 9.x pinned

Comments

@chengenzhao
Copy link

@chengenzhao chengenzhao commented Mar 20, 2019

Hi:
Today JDK 12 is released and one interesting change is they make javafx.scene.control.skin.TextFieldSkin members private
thus for JFoenix we will get some exception like:
java.lang.IllegalAccessException: class com.jfoenix.skins.JFXTextFieldSkin cannot access a member of class javafx.scene.control.skin.TextFieldSkin with modifiers "private"
at java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:355)

so any ideas how we should fix this problem?
@chengenzhao

This comment has been minimized.

Sign in to view
Copy link
Author

@chengenzhao chengenzhao commented Mar 20, 2019 •
edited

and I guess this problem has something to do with this issue:
https://bugs.openjdk.java.net/browse/JDK-8207942
@cupendra

This comment has been minimized.

Sign in to view
Copy link

@cupendra cupendra commented Mar 20, 2019

Hi, we did face the relevant problem with the same component JFXTextFieldSkin while launching the application.

Here is the exception.
Exception in thread "JavaFX Application Thread" java.lang.NullPointerException
at com.jfoenix.skins.JFXTextFieldSkin.updateTextPos(JFXTextFieldSkin.java:109)
at com.jfoenix.skins.JFXTextFieldSkin.layoutChildren(JFXTextFieldSkin.java:93)
at javafx.scene.control.Control.layoutChildren(Control.java:601)

java.version : 12
java.vm.version : 12+33

we use java fx bundle 12

Thought this is relevant. Let me know if this needs to be created as a new issue
@micheljung

This comment has been minimized.

Sign in to view
Copy link
Contributor

@micheljung micheljung commented Mar 30, 2019

I tried looking into it but @jfoenixadmin it seems that the branch JFoenix-9.0.0 hasn't been kept up to date since August 2018 :-(

I tried updating it but went over my head.
@jfoenixadmin

This comment has been minimized.

Sign in to view
Copy link
Owner

@jfoenixadmin jfoenixadmin commented Apr 3, 2019 •
edited

@micheljung no worries, I'll do the merge now.
However I'm not sure this will fix the compatibility with JDK 12
@jonathansim97 jonathansim97 mentioned this issue Apr 22, 2019
Closed
@jfoenixadmin jfoenixadmin added the JDK 12 label May 22, 2019
@Terkea

This comment has been minimized.

Sign in to view
Copy link

@Terkea Terkea commented Jun 2, 2019

Same problem here with jfoenix 9.0.9
Has anybody figured out how to fix it?
@TheRedSpy15

This comment has been minimized.

Sign in to view
Copy link

@TheRedSpy15 TheRedSpy15 commented Jun 19, 2019

I am also having a problem with jfoenix 9.0.9 and JDK 12
@TheRedSpy15

This comment has been minimized.

Sign in to view
Copy link

@TheRedSpy15 TheRedSpy15 commented Jun 19, 2019

@jfoenixadmin not sure if you saw this already:

https://stackoverflow.com/a/55892520
@jfoenixadmin

This comment has been minimized.

Sign in to view
Copy link
Owner

@jfoenixadmin jfoenixadmin commented Jul 4, 2019 •
edited

@TheRedSpy15 that's how we are using reflection to access private fields. however I suspect that the field either renamed or removed thus causing this issue.
@sanjitmisra

This comment has been minimized.

Sign in to view
Copy link

@sanjitmisra sanjitmisra commented Jul 15, 2019

I am facing this issue as well
java.lang.IllegalAccessException: class com.jfoenix.skins.JFXTextAreaSkin cannot access a member of class javafx.scene.control.skin.TextAreaSkin
@dubbadhar

This comment has been minimized.

Sign in to view
Copy link

@dubbadhar dubbadhar commented Jul 19, 2019

@jfoenixadmin when will get a fix for this :(
@mmahapat

This comment has been minimized.

Sign in to view
Copy link

@mmahapat mmahapat commented Oct 10, 2019

is this fixed??
@kowlown

This comment has been minimized.

Sign in to view
Copy link

@kowlown kowlown commented Oct 18, 2019

Not fixed yet
@jfoenixadmin jfoenixadmin added the pinned label Oct 20, 2019
This was referenced Nov 17, 2019
Open
Open
Open
@nus-pe-bot nus-pe-bot mentioned this issue Nov 20, 2019
Open
@Dosibo-dot

This comment has been minimized.

Sign in to view
Copy link

@Dosibo-dot Dosibo-dot commented Dec 10, 2019

Am also faced with the same issue

java.lang.IllegalAccessException: class com.jfoenix.skins.JFXTextFieldSkin cannot access a member of class javafx.scene.control.skin.TextFieldSkin with modifiers "private"
@pramudKumarage

This comment has been minimized.

Sign in to view
Copy link

@pramudKumarage pramudKumarage commented Dec 22, 2019

did any one resolve this issue ?
@anis00723

This comment has been minimized.

Sign in to view
Copy link

@anis00723 anis00723 commented Jan 21, 2020

Any fix?
@aviollet

This comment has been minimized.

Sign in to view
Copy link

@aviollet aviollet commented Jan 31, 2020

any fix ?
@astonbitecode

This comment has been minimized.

Sign in to view
Copy link

@astonbitecode astonbitecode commented Feb 7, 2020 •
edited

Are there any plans for making JFoenix compatible with versions of Java greater than 11?
@OhenebaAduhene

This comment has been minimized.

Sign in to view
Copy link

@OhenebaAduhene OhenebaAduhene commented Feb 28, 2020

any fix to the access block to JFXTextfield and JFXPassword in jdk12?
@ysyesilyurt

This comment has been minimized.

Sign in to view
Copy link

@ysyesilyurt ysyesilyurt commented Apr 25, 2020 •
edited

@jfoenixadmin We need some kind of a fix for this bug please, I don't want to downgrade to jdk11 just for this issue :(
@seinecle

This comment has been minimized.

Sign in to view
Copy link

@seinecle seinecle commented Apr 26, 2020

Same here. Won't use the library as I am on JDK 14 / JavaFX 12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JDK 12 Type: Bug Version: 9.x pinned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.