Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak search by absolute intensities #245

Open
tsufz opened this issue May 12, 2020 · 5 comments
Open

Peak search by absolute intensities #245

tsufz opened this issue May 12, 2020 · 5 comments
Labels

Comments

@tsufz
Copy link
Member

@tsufz tsufz commented May 12, 2020

During the Virtual Podium I was asked if we could add absolute intensity search to MassBank? I dunno if this makes sense, but should be no big issue.

@tsufz tsufz added the enhancement label May 12, 2020
@sneumann
Copy link
Member

@sneumann sneumann commented May 13, 2020

I would need to be convinced, the absolute intensity depends on instrument, sample concentration etc. Yours, Steffen

@schymane
Copy link
Member

@schymane schymane commented May 13, 2020

Well ... maybe people could input absolute intensity but we would have to relativize it and search on that (which would mean the underlying search would be the same as already exists)?
Is the current search dependent on input of relative intensity only?

@tsufz
Copy link
Member Author

@tsufz tsufz commented May 13, 2020

Hmm, but we need the absolute intensity of the base peak to recalculate to absolute values. I guess, the search algorithm could be the same with some extension. Relative intensity search is the status. I am also not conviced about the absolute intensites. If they would be stable and independent from sample conditions (they are not as @sneumann said), we would have less problems with similarity search at all. I suggest to keep the status, recalculation to relative values is no magic.

@schymane
Copy link
Member

@schymane schymane commented May 13, 2020

Well - if people input absolute intensities, calculating relative intensities is trivial too, based on max(I) of the provided list. There's little point searching on absolute intensities, but one could provide a service to accept absolute intensities, but search relative behind the scenes, this is what any algorithm does anyway

@tsufz
Copy link
Member Author

@tsufz tsufz commented May 13, 2020

Okay, but this needs some adjustment in the pipeline after peaklist import. I think it is doable and we should think from the service view, not from the freak view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.