Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up1 - 2*alpha confidence intervals returned by mm_diffs() #37
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hoellers commentedMay 12, 2020
Please specify whether your issue is about:
It seems that there is an issue with calculation of confidence intervals in mm_diffs. Instead of returning a 1 - alpha confidence interval, a 1 - 2*alpha confidence interval is currently returned.
In lines 71-72 of mm_diffs(), the confidence intervals are calculated so:
But the function documentation specifies that alpha is a "A numeric value indicating the significance level at which to calculate confidence intervals for the MMs (by default 0.95, meaning 95-percent CIs are returned)." The default of alpha = 0.05 gives a 90-percent confidence interval as of right now. I'm sure the solution is obvious to you; changing alpha to alpha/2 in both cases above would fix the issue. Or adding + (alpha/2) within qnorm(), which seems to be what is done in mm() and amce_diffs()
This is mainly a problem for subsequent plotting, I think.
Thank you for this package, it's awesome!
Put your code here: