Skip to content

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PlainTextExtractor to just extract text #452

Closed
ruebot opened this issue Apr 21, 2020 · 1 comment
Closed

Update PlainTextExtractor to just extract text #452

ruebot opened this issue Apr 21, 2020 · 1 comment
Assignees
@ruebot
Labels
App DataFrames Scala enhancement

Comments

@ruebot
Copy link
Member

@ruebot ruebot commented Apr 21, 2020

Currently there is a fair bit of overlap between the PlainTextExtractor and WebPagesExtractor. Really, the only different between them now is the name of the content/text column, and WebPagesExtractor has some additional columns.

I propose that PlainTextExtractor moves to something that is more in the spirit of its name. It should run RemoveHTMLDF, RemoveHTTPHeaderDF, a DataFrame version of ExtractBoilerpipeTextRDD, and output a single column (csv or parquet), or possibly a single text file.
@ruebot ruebot self-assigned this Apr 21, 2020
@ianmilligan1

This comment has been minimized.

Sign in to view
Copy link
Member

@ianmilligan1 ianmilligan1 commented Apr 21, 2020

Yes, that's a great idea @ruebot - I think that's more in spirit of its name, and you could imagine using it in a pipeline through to text analysis better than WebPagesExtractor.
ruebot added a commit that referenced this issue Apr 21, 2020
@ruebot
Update PlainTextExtractor to output a single column; text.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
5ef2920 
- Resolves #452
- PlainTextExtractor runs RemoveHTML, and ExtractBoilerplate on
`content`
- Update test
@ruebot ruebot mentioned this issue Apr 21, 2020
Merged
ianmilligan1 pushed a commit that referenced this issue Apr 22, 2020
@ruebot
Update PlainTextExtractor to output a single column; text. (#453)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e91d01f 
- Resolves #452
- PlainTextExtractor runs ExtractBoilerplate on `content`
- Update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruebot ruebot

Labels
App DataFrames Scala enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Update PlainTextExtractor to output a single column; text.
2 participants
@ruebot @ianmilligan1
You can’t perform that action at this time.