Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up test descriptions, addresses #372. #416

Merged
merged 5 commits into from Jan 21, 2020
Merged

Conversation

@ruebot
Copy link
Member

ruebot commented Jan 21, 2020

GitHub issue(s): #372

What does this Pull Request do?

  • Clean up test descriptions
  • Rename typo filename
  • Remove potentially unnecessary tests

How should this be tested?

  • Copy editing
  • TravisCI
- Rename typo filename
- Remove potentially unnecessary tests
@ruebot ruebot requested review from ianmilligan1 and SamFritz Jan 21, 2020
Copy link
Member

ianmilligan1 left a comment

These look great (and I'll leave the the actual tests to TravisCI). Some half hearted comments re: copy editing, which you can take or leave. 😄

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #416 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #416   +/-   ##
=======================================
  Coverage   77.96%   77.96%           
=======================================
  Files          41       41           
  Lines        1570     1570           
  Branches      292      292           
=======================================
  Hits         1224     1224           
  Misses        218      218           
  Partials      128      128
@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Jan 21, 2020

Ok, I'll put those back in. I stand corrected.

ruebot added 2 commits Jan 21, 2020
Copy link
Member

SamFritz left a comment

Looks good here @ruebot. The notes in this review are more just questions to prompt a change if necessary.

@@ -43,21 +43,21 @@ class RecordRDDTest extends FunSuite with BeforeAndAfter {
sc = new SparkContext(conf)
}

test("no valid pages") {
test("Expect no valid pages") {

This comment has been minimized.

Copy link
@SamFritz

SamFritz Jan 21, 2020

Member

should this also include RDD at the end?

@ianmilligan1 ianmilligan1 merged commit ffef735 into master Jan 21, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 71b459c...4db3c10
Details
codecov/project 77.96% remains the same compared to 71b459c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 deleted the issue-372-tests branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.