Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd graphml output to CommandLineApp and DomainGraphExtractor. #438
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 9, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 78.04% 78.18% +0.13%
==========================================
Files 43 43
Lines 1558 1586 +28
Branches 286 289 +3
==========================================
+ Hits 1216 1240 +24
- Misses 217 218 +1
- Partials 125 128 +3 |
|
See |
|
|
This comment has been minimized.
This comment has been minimized.
|
@ianmilligan1 sure, let's use the following as a commit message: Add graphml output to CommandLineApp and DomainGraphExtractor.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedApr 9, 2020
GitHub issue(s): #435
What does this Pull Request do?
Add graphml output to CommandLineApp and DomainGraphExtractor.
How should this be tested?
TravisCI +
Those both should have the same line count.
For example:
Additional Notes:
I should add a test as well for WriteGraphmlDF similar to what we have for WriteGexf. So, don't merge this right away, but feel free to test it and make sure it works.
This might also take care of the remainder of #223 and supersede #397?👋 @SinghGursimran