Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite data management user guide a bit #1409

Merged
merged 6 commits into from May 21, 2020
Merged

Conversation

@benclifford
Copy link
Contributor

benclifford commented Oct 28, 2019

putting this up for people to look at, but I want to work on it more

@danielskatz
Copy link
Collaborator

danielskatz commented May 1, 2020

Is this still active? And does it make sense to look at now?

@benclifford benclifford marked this pull request as ready for review May 4, 2020
@benclifford
Copy link
Contributor Author

benclifford commented May 4, 2020

@danielskatz I just re-read this text, and I'm happy for it to be merged into master.

@danielskatz danielskatz removed the draft label May 4, 2020
docs/userguide/data.rst Outdated Show resolved Hide resolved
docs/userguide/data.rst Outdated Show resolved Hide resolved
docs/userguide/data.rst Outdated Show resolved Hide resolved
docs/userguide/data.rst Outdated Show resolved Hide resolved
docs/userguide/futures.rst Outdated Show resolved Hide resolved
@danielskatz
Copy link
Collaborator

danielskatz commented May 4, 2020

@benclifford - I've made a bunch of small comments in-line. In addition, I think it would make sense to add a little general text under the staging providers header that explains at that point the difference between the FTP, HTTP, HTTPS: separate task staging and FTP, HTTP, HTTPS: in-task staging sections that follow, something like - if you have this situation, use this part below...

@danielskatz
Copy link
Collaborator

danielskatz commented May 4, 2020

The rest of this looks good to me

danielskatz added 3 commits May 5, 2020
@danielskatz
Copy link
Collaborator

danielskatz commented May 5, 2020

I've gone ahead and made the changes that are small.
I think the one more thing that is needed is to add a little general text under the staging providers header that explains at that point the difference between the FTP, HTTP, HTTPS: separate task staging and FTP, HTTP, HTTPS: in-task staging sections that follow, something like - if you have this situation, use this part below...

@yadudoc yadudoc added this to the 1.0 milestone May 21, 2020
@yadudoc
Copy link
Member

yadudoc commented May 21, 2020

@danielskatz why don't we merge this now. Since you've already done a fair bit of testing with staging, can you try re-reading some of this and recommend changes in a separate PR?

@yadudoc yadudoc self-requested a review May 21, 2020
@danielskatz
Copy link
Collaborator

danielskatz commented May 21, 2020

I suggest we just merge this PR for now - It already has a bunch of changes I added a few weeks ago, and I don't have a good suggestion for the part that I thought still needed something more.

@yadudoc yadudoc merged commit f21f27f into master May 21, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@yadudoc yadudoc deleted the benc-data-doc-improvement branch May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.