Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTypes of features should be validated. #25
Comments
zero323
changed the title
Type of features should be validated.
Types of features should be validated.
Mar 28, 2019
This comment has been minimized.
This comment has been minimized.
Thanks. Good points. Will fix. |
leeper
added
the
bug
label
Apr 7, 2019
leeper
referenced this issue
Apr 7, 2019
Closed
Error in model.frame.default(weights, data = list(OUTCOME = c(1, 1, 1, : object is not a matrix #12
leeper
added
the
enhancement
label
Apr 7, 2019
leeper
closed this
in
4d5edb2
Apr 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zero323 commentedMar 28, 2019
Please specify whether your issue is about:
If you are reporting (1) a bug or (2) a question about code, please supply:
Right now package doesn't validate if
features
arefactors
. It leads to rather errors like thisThat's because
make_term_levels_df
blindly assumes that features arefactors
and ends up with a list ofNULLs
The problem affects at least
amce
,cj
andmm
.A quick fix would be to simply test if that's the case:
Alternatively one could attempt to fix the problem by explicitly casting to factors (maybe with a warning).