Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Frackit: a framework for stochastic fracture network generation and analysis #2263

Open
whedon opened this issue May 27, 2020 · 16 comments

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented May 27, 2020

Submitting author: @dglaeser (Dennis Gläser)
Repository: https://git.iws.uni-stuttgart.de/tools/frackit
Version: v1.1
Editor: Pending
Reviewer: Pending
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @dglaeser. Currently, there isn't an JOSS editor assigned to your paper.

@dglaeser if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label May 27, 2020
@whedon
Copy link
Collaborator Author

@whedon whedon commented May 27, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon
Copy link
Collaborator Author

@whedon whedon commented May 27, 2020

Reference check summary:

OK DOIs

- 10.18419/opus-289 is OK
- 10.1016/j.cageo.2017.02.002 is OK
- 10.1016/j.advwatres.2011.03.007 is OK
- doi.org/10.1016/j.advwatres.2017.10.031 is OK
- 10.1002/nme.2579 is OK
- 10.1016/j.advwatres.2017.10.036 is OK
- 10.1016/j.jcp.2014.12.047 is OK
- 10.1016/j.jcp.2017.07.041 is OK
- 10.1016/j.cageo.2019.06.014 is OK
- 10.1016/j.jcp.2017.12.003 is OK
- 10.1016/j.applthermaleng.2011.01.038 is OK
- 10.1016/j.rser.2014.04.068 is OK

MISSING DOIs

- https://doi.org/10.1016/j.cageo.2015.04.012 may be missing for title: Fracture-based modeling of complex flow and CO2 migration in three-dimensional fractured rocks
- https://doi.org/10.1016/j.jhydrol.2015.08.065 may be missing for title: Finite element generation of arbitrary 3-D fracture networks for flow analysis in complicated discrete fracture networks
- https://doi.org/10.5194/hess-2018-397-rc2 may be missing for title: Stochastic modeling of flow and conservative transport in three-dimensional discrete fracture networks
- https://doi.org/10.1007/s13137-019-0116-8 may be missing for title: A hybrid-dimensional discrete fracture model for non-isothermal two-phase flow in fractured porous media
- https://doi.org/10.1002/nme.6238 may be missing for title: Finite volume discretization for poroelastic media with fractures modeled by contact mechanics
- https://doi.org/10.1007/s13137-019-0117-7 may be missing for title: A stabilized Lagrange multiplier finite-element method for flow in porous media with fractures
- https://doi.org/10.1007/s10596-018-9778-9 may be missing for title: Unified approach to discretization of flow in fractured porous media
- https://doi.org/10.1007/s12665-014-3211-z may be missing for title: Numerical simulation and evaluation of groundwater resources in a fractured chalk aquifer: a case study in Zinder well field, Niger
- https://doi.org/10.1016/j.fuel.2011.08.037 may be missing for title: Comparative evaluation of immiscible, near miscible and miscible CO2 huff-n-puff to enhance oil recovery from a single matrix–fracture system (experimental and simulation studies)

INVALID DOIs

- https://doi.org/10.1016/j.petrol.2019.106350 is INVALID because of 'https://doi.org/' prefix
@danielskatz
Copy link

@danielskatz danielskatz commented May 27, 2020

@whedon generate pdf

@danielskatz
Copy link

@danielskatz danielskatz commented May 27, 2020

@whedon check repository

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 27, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.30 s (846.9 files/s, 88377.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                   126           2259           6298           8329
C++                             51            829            629           3792
Markdown                         6            363              0           1552
CMake                           53             92            103            608
Python                          12            191            232            559
TeX                              1             33              0            258
GLSL                             2              7              3             56
-------------------------------------------------------------------------------
SUM:                           251           3774           7265          15154
-------------------------------------------------------------------------------


Statistical information for the repository '2263' was gathered on 2020/05/27.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Dennis.Glaeser                 481         33742          10624          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Dennis.Glaeser            23118           68.5          1.7               30.70
@danielskatz
Copy link

@danielskatz danielskatz commented May 27, 2020

👋 @openjournals/dev - generating the PDF seems to be failing - can you check what's going wrong?

@arfon
Copy link
Member

@arfon arfon commented May 27, 2020

@whedon generate pdf

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 27, 2020

@arfon
Copy link
Member

@arfon arfon commented May 27, 2020

👋 @openjournals/dev - generating the PDF seems to be failing - can you check what's going wrong?

I think Whedon might be struggling a little here due to the large size of the (very nice) images in this paper.

@danielskatz
Copy link

@danielskatz danielskatz commented May 27, 2020

yes, this is also causing a lot of slowness when I try to display the paper in github.

@danielskatz
Copy link

@danielskatz danielskatz commented May 27, 2020

👋 @dglaeser - if you can reduce the size of the images without losing content, please do. If not, that's ok.

@danielskatz
Copy link

@danielskatz danielskatz commented May 27, 2020

Also note a bunch of references may be missing DOIs. As you make changes to the .md, .bib, etc. please enter @whedon generate pdf as a new command here to check the results

@danielskatz
Copy link

@danielskatz danielskatz commented May 27, 2020

👋 @dglaeser - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS last week, we've had > 60 papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

@dglaeser
Copy link

@dglaeser dglaeser commented May 27, 2020

Thanks a lot for your quick responses! I fixed the missing and failing dois and downsampled some of the images

@dglaeser
Copy link

@dglaeser dglaeser commented May 27, 2020

@whedon generate pdf

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.