Skip to content

/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary buffer copying #18

Open
ruebot opened this issue Jul 10, 2017 · 3 comments

Comments

@ruebot
Copy link
Member

commented Jul 10, 2017 •
edited

From TODO in src/main/java/io/archivesunleashed/data/WarcRecordUtils.java and src/main/java/io/archivesunleashed/data/ArcRecordUtils.java that will be removed with the resolution of #3:

These methods work fine, but there's a lot of unnecessary buffer copying, which is terrible from a performance perspective.

@ruebot ruebot added the enhancement label Jul 10, 2017

@ianmilligan1

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 6, 2018

Do we see ourselves as tackling this?
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 8, 2018

I think we need to leave this open, if that is what you're asking.

@ruebot ruebot added the RA-Task label Feb 5, 2018

@ruebot ruebot added this to To Do in 1.0.0 Release of AUT Aug 13, 2018

@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Aug 21, 2019

@lintool should be the decider on closing this or leaving it open, since it looks like he added it https://github.com/lintool/warcbase/blame/cab311ed8b0bceb666865fa76dd3bc5a86402e13/warcbase-core/src/main/java/org/warcbase/data/WarcRecordUtils.java#L40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RA-Task enhancement
Projects
  
To Do in 1.0.0 Release of AUT
Milestone
No milestone
2 participants
@ruebot @ianmilligan1
You can’t perform that action at this time.