Skip to content

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP8 Naming - UDFs, App method names, DataFrame names, and filters. #468

Closed
ruebot opened this issue May 27, 2020 · 4 comments
Closed

PEP8 Naming - UDFs, App method names, DataFrame names, and filters. #468

ruebot opened this issue May 27, 2020 · 4 comments
Assignees
@lintool @ianmilligan1 @SamFritz
Labels
discussion
Projects
1.0.0 Release of AUT

Comments

@ruebot
Copy link
Member

@ruebot ruebot commented May 27, 2020

Let's evaluate how we've named everything; UDFs, App method names, DataFrame names, and filters.

Are we all good with how we've named everything?

Do we need to change anything before a 1.0.0 release?

See also #467
@ruebot ruebot added the discussion label May 27, 2020
@ruebot ruebot added this to In Progress in 1.0.0 Release of AUT May 27, 2020
@ruebot ruebot mentioned this issue May 29, 2020
Merged
@lintool
Copy link
Member

@lintool lintool commented May 29, 2020

My thoughts: In Python, I would default to PEP8 unless there's a convincing reason otherwise: https://www.python.org/dev/peps/pep-0008/

Apps are most like Classes, so I would go CamelCase. Note, it says:

Note: When using acronyms in CapWords, capitalize all the letters of the acronym. Thus HTTPServerError is better than HttpServerError.

UDFs are like methods, so should follow standard snake_case.
@ruebot
Copy link
Member Author

@ruebot ruebot commented May 29, 2020

@lintool anything on the Scala side? If not, I'll get some PRs ready for aut, documentation, and notebooks.
@ruebot
Copy link
Member Author

@ruebot ruebot commented May 29, 2020

  • ExtractPopularImages
  • WriteGexf
  • WriteGraphml
@ruebot ruebot mentioned this issue May 29, 2020
Merged
@ruebot ruebot changed the title [DISCUSSION] Naming - UDFs, App method names, DataFrame names, and filters. PEP8 Naming - UDFs, App method names, DataFrame names, and filters. May 30, 2020
@ruebot
Copy link
Member Author

@ruebot ruebot commented May 30, 2020

Resolved with 8037745
@ruebot ruebot closed this May 30, 2020
1.0.0 Release of AUT automation moved this from In Progress to Done May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lintool lintool

@ianmilligan1 ianmilligan1

@SamFritz SamFritz

Labels
discussion
Projects
1.0.0 Release of AUT
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@ruebot @lintool @ianmilligan1 @SamFritz
You can’t perform that action at this time.