Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different results between MetFrag CLI and Web #39

Open
cjhjhj opened this issue Jun 1, 2020 · 6 comments
Open

Different results between MetFrag CLI and Web #39

cjhjhj opened this issue Jun 1, 2020 · 6 comments

Comments

@cjhjhj
Copy link

@cjhjhj cjhjhj commented Jun 1, 2020

Hello,
I ran MetFrag CLI and Web for a feature of neutral mass = 80.038114 against HMDB4, but got different results. CLI gave only pyrimidine as a candidate, but Web gave pyrimidine and pyrazine. Please let me know how I can get two candidates from CLI. For CLI, SDF file of HMDB4 was downloaded and used locally. Parameters are as follows,

PeakListPath = ms2.txt
LocalDatabasePath = hmdb.sdf
NeutralPrecursorMass = 80.038114
DatabaseSearchRelativeMassDeviation = 10
FragmentPeakMatchRelativeMassDeviation = 10
IsPositiveIonMode = True
PrecursorIonMode = 1
MetFragScoreTypes = FragmenterScore
MetFragScoreWeights = 1.0
MetFragCandidateWriter = CSV
SampleName = metfrag_result
ResultsPath = .
MaximumTreeDepth = 2
MetFragPreProcessingCandidateFilter = UnconnectedCompoundFilter
MetFragPostProcessingCandidateFilter = InChIKeyFilter

Thanks.

Screenshot of MetFragWeb
image

ms2.txt

@sneumann
Copy link
Member

@sneumann sneumann commented Jun 2, 2020

Hi, I didn't yet get across to reproduce, but there was a recent report in #38
that mass rounding might be different between CLI and web version. Could that
be the case here as well ? Yours, Steffen

@cjhjhj
Copy link
Author

@cjhjhj cjhjhj commented Jun 2, 2020

I don't think it's a mass rounding problem since mass values of pyrimidine and pyrazine are identical.
In short,
MetFrag CLI (for my feature) -> pyrimidine
MetFrag Web (for the same feature) -> pyrimidine and pyrazine
I think MetFrag Web is correct. I want to know why CLI did not find pyrazine.
Thanks.

@schymane
Copy link
Contributor

@schymane schymane commented Jun 5, 2020

@schymane
Copy link
Contributor

@schymane schymane commented Jun 5, 2020

@cjhjhj
Copy link
Author

@cjhjhj cjhjhj commented Jun 5, 2020

This could be due to you using a different version of HMDB … the exact database used in MetFragWeb (in the screenshot you show) is available from here: https://zenodo.org/record/3375500 and should be used via the localCSV option with the CLI (rather than an SDF downloaded from HMDB). Can you confirm that this file gives you the same candidates as your web query?

With "localCSV" option and the above CSV file, I could have two candidates as the same as web query. By the way, when I tried "localSDF" and SDF file (same mass query), I got some errors and could not obtaine the result.
It would be great if I could use a SDF file directly. Most databases support SDF file, but not CSV. The converter (SDF to CSV) did not work well for the latest HMDB SDF file.
Thanks.

@schymane
Copy link
Contributor

@schymane schymane commented Jun 5, 2020

We also had issues with the HMDB SDF, hence we created and validated the CSV file. It's easier to add extra functionality to the CSV than the SDF. However, these local CSVs are a temporary solution and will eventually be integrated into a database so that you do not have to specify external files. This functionality will be released when ready but is not yet available.
Please use the CSV for now, note we have a much larger range of CSVs available at the moment than SDFs, but if you want a flexible workflow, maybe it's best to work with both formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.