Skip to content

/ prediction

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ridge::linearRidge prediction #44

Closed
dfrankow opened this issue Mar 18, 2020 · 3 comments
Closed

Add support for ridge::linearRidge prediction #44

dfrankow opened this issue Mar 18, 2020 · 3 comments
Labels
enhancement

Comments

@dfrankow
Copy link
Contributor

@dfrankow dfrankow commented Mar 18, 2020

I'm trying to get margins for ridge regression. To do that, I need the predictions package to support ridge::linearRidge. I have a PR I'll send for review.
@dfrankow
Copy link
Contributor Author

@dfrankow dfrankow commented Mar 18, 2020 •
edited

Here's the pull request: #45
@leeper leeper added the enhancement label Apr 19, 2020
@leeper
Copy link
Owner

@leeper leeper commented Jun 20, 2020

thanks!
@leeper leeper closed this Jun 20, 2020
@dfrankow
Copy link
Contributor Author

@dfrankow dfrankow commented Jun 20, 2020

You're welcome.

However, I concluded I won't be able to make progress on margins for ridge. See leeper/margins#140 (comment).

I hope this change is still helpful in some way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@dfrankow @leeper
You can’t perform that action at this time.