Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upNot all collections will produce all derivatives #10
Comments
ruebot
added
the
bug
label
Mar 4, 2019
This comment has been minimized.
This comment has been minimized.
At minimum, we produce : a fulltext file, domains file, and graphml file. We may or may not produce a So, the question is where is the best place wrap a couple things in a @greebie let me know what you think, and if you want to take this on. If you just want to let me know what you think are the best places, I can take care of implementing it. |
This comment has been minimized.
This comment has been minimized.
I think the best way is to create a check function that takes a function and runs the try catch. For instance:
Then you can add To make this work generally, we will need to include a network function that looks something like this:
|
This comment has been minimized.
This comment has been minimized.
I am willing to take this on also. :) |
ianmilligan1
assigned
greebie
Mar 5, 2019
This comment has been minimized.
This comment has been minimized.
Great, thanks @greebie - I assigned you do this. Seems like you've got a good plan above. |
This comment has been minimized.
This comment has been minimized.
I'm going to have to wait to wait for #30 otherwise I'll have merging issues. |
This comment has been minimized.
This comment has been minimized.
Okay - close to a PR. The approach I took was very similar, but I decided to just show empty graphs on a fail, but included a file checker script to check the existence of all derivative files. At this stage the notebook is not using either graphml or the filtered text derivatives, but I included functions to check those for future use. |
greebie
referenced this issue
Mar 8, 2019
Closed
Include functions for testing existence of derivatives. #10 #37
This comment has been minimized.
This comment has been minimized.
Closed with aed4e11. |
ruebot commentedMar 2, 2019
The notebook(s) need to be updated with conditions if particular derivatives don't exist. Right now, it expects all possible derivatives to be supplied.