Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Researchgate translator #2199

Open
wants to merge 7 commits into
base: master
from
Open

Updated Researchgate translator #2199

wants to merge 7 commits into from

Conversation

@step21
Copy link

step21 commented Jun 27, 2020

Hey, with this update ResearchGate translator kind of works again. Sometimes item type still fails to be detected though, as classes are sometimes there or not... or maybe detectWeb also could use RIS directly?
Would be great to merge this especially for items that have no doi, let me know what you think and if it needs any changes.

Copy link
Collaborator

adam3smith left a comment

Thanks! I have one question in line. Beyond that, please remove all the debugging code (if there's a particularly useful step you can lead 1-2 in, but currently that's too much) and relint

if (!type) {
Zotero.debug('trying different way');
type = text(doc, "b[research-meta-type]");

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jun 28, 2020

Collaborator

I'm seeing [data-testid="research-meta-type"]
Are you sure about this?

This comment has been minimized.

Copy link
@step21

step21 Jun 28, 2020

Author

Yeah, I might be wrong, but hard to say with tags not always being the same. (plus I am not always sure how text() or attr() filters and couldn't find anything in the docs. It definitely is not XPaths anymore.

This comment has been minimized.

Copy link
@adam3smith
step21 added 3 commits Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.