Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: DearScholar: A mobile application to conduct qualitative and quantitative diary research #2354

Open
whedon opened this issue Jun 18, 2020 · 21 comments

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Jun 18, 2020

Submitting author: @pmkruyen (Peter Kruyen)
Repository: https://github.com/pmkruyen/dearscholar.git
Version: 1.48
Editor: @cMadan
Reviewer: Pending
Managing EiC: Kevin M. Moerman

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @pmkruyen. Currently, there isn't an JOSS editor assigned to your paper.

@pmkruyen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Jun 18, 2020
@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 18, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 18, 2020

@arfon
Copy link
Member

@arfon arfon commented Jun 18, 2020

👋 @pmkruyen - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS earlier in the month we've had a very large number of papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

@pmkruyen
Copy link

@pmkruyen pmkruyen commented Jun 18, 2020

Thanks @arfon for your message. Completely understand. Your bot Whedon is asking me to suggest reviews in the first message above, should I do this or wait till further notice?

Regards,
Peter

@arfon
Copy link
Member

@arfon arfon commented Jun 18, 2020

Thanks @arfon for your message. Completely understand. Your bot Whedon is asking me to suggest reviews in the first message above, should I do this or wait till further notice?

Feel free to suggest some reviewers now (please avoid mentioning them directly to avoid unnecessary GitHub notifications for folks) which will help when an editor is assigned.

@pmkruyen
Copy link

@pmkruyen pmkruyen commented Jun 18, 2020

My suggestions for reviewers based on their expertise:

  • gcdeshpande (mobile apps)
  • olade014 (android)
  • alletsee (survey research and longitudinal data collection)
  • darthpathos (survey research and longitudinal data collection)
  • andytwoods (javascript, psychology, online research)
@arfon
Copy link
Member

@arfon arfon commented Jun 23, 2020

@whedon check repository

1 similar comment
@kthyng
Copy link

@kthyng kthyng commented Jun 24, 2020

@whedon check repository

@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 24, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=16.09 s (92.7 files/s, 37931.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                     650          24592          21278         185751
C                                4          15087          70293         140007
CSS                             91             54           1210          53217
Markdown                       143           6762              0          20157
LESS                           255            453            553          19910
JSON                            91              0              0          13392
TypeScript                     107            541           2499           4764
Java                            24            861            829           4738
Objective C                     15            990            467           3934
C/C++ Header                    22            504          10073           1994
XML                             32            177            214           1879
HTML                            12             95             44            564
Sass                            14             18             12            556
CoffeeScript                     2            110             61            507
C#                               3             67             63            305
C++                              4             32              2            127
Swift                            1             22              1            120
TeX                              1             10              0            110
DOS Batch                        3              3              0             75
YAML                             8              6              0             61
PowerShell                       1              8             20             39
Bourne Shell                     1             10             23             33
make                             1             11              3             22
Gradle                           1              4              8             18
Ruby                             2              4              1             16
INI                              1              0              0             13
SVG                              2              0              0              6
-------------------------------------------------------------------------------
SUM:                          1491          50421         107654         452315
-------------------------------------------------------------------------------
@arfon
Copy link
Member

@arfon arfon commented Jun 24, 2020

@pmkruyen - @kthyng and I are trying to get an idea of the code contribution here. Could you point to the main areas of the repository where you've written new code for this project? It looks like a lot of the code in here comes from the framework you've been using.

@pmkruyen
Copy link

@pmkruyen pmkruyen commented Jun 24, 2020

@arfon @kthyng thanks for checking... I have built DearScholar using Framework7 indeed; dearscholar.js--the heart of the project and a lot of work--; plus all the html-files and dearscholar.css are mine (code solely written by me); also see the table at the bottom of the README file. Best Peter

@pmkruyen
Copy link

@pmkruyen pmkruyen commented Jun 24, 2020

@arfon and @kthyng To follow up, I just realized, I included the complete codebase of Framework7 in my repro as matter of convenience, but (obviously) not everything is needed for DearScholar to work.

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 29, 2020

👋 @cMadan - you were suggested as the editor for this submission - would you be willing to do so?

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 29, 2020

@whedon invite @cMadan as editor

@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 29, 2020

@cMadan has been invited to edit this submission.

@cMadan
Copy link
Member

@cMadan cMadan commented Jun 29, 2020

@whedon set @cMadan as editor

@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 29, 2020

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands
@cMadan
Copy link
Member

@cMadan cMadan commented Jun 29, 2020

@whedon assign @cMadan as editor

@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 29, 2020

OK, the editor is @cMadan

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 29, 2020

thanks!

@cMadan
Copy link
Member

@cMadan cMadan commented Jun 30, 2020

@pmkruyen, I've looked over your submission and have three initial comments:

  1. Your license has some additional text at the top, in addition to a standard OSI license. Publishing in JOSS requires that you only use a standard OSI-compliant license with no modifications.

  2. I would appreciate if you could add a few screenshots (just one picture concatenating a screenshots from a few different parts of the app). Since it's very front-end oriented in that research participants would be using it, it would be helpful to see how it looks 'out of the box', though I do understand that it's just a bit of HTML code for another researcher to change this.

  3. It would be helpful to provide the MySQL database initialisation code for setting up the databases for the first time. I have a feeling that with 10 tables, someone could easily make a typo, or set a column to the wrong data format, so it would be great to provide the syntax for automating that step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.