Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSet Maximum Edges #60
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Sep 5, 2018
Collaborator
The problem graph (2402) has over 2 million edges. The math in my head is that each edge is worth about 300 bytes (based on a rough measure of the number of characters in a typical edge). Therefore limiting to 1,000,000 edges would keep the file below approximately 300k.
|
The problem graph (2402) has over 2 million edges. The math in my head is that each edge is worth about 300 bytes (based on a rough measure of the number of characters in a typical edge). Therefore limiting to 1,000,000 edges would keep the file below approximately 300k. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Sep 5, 2018
Collaborator
@ruebot @ianmilligan1 I'm wondering if this is a good time to add --max_nodes & --max_edge flags or should we just go with hard code for now?
|
@ruebot @ianmilligan1 I'm wondering if this is a good time to add --max_nodes & --max_edge flags or should we just go with hard code for now? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ianmilligan1
Sep 5, 2018
Member
Do you have a sense of how many of the files would have more than a million edges?
|
Do you have a sense of how many of the files would have more than a million edges? |
greebie
referenced this issue
Sep 5, 2018
Merged
Quit graphpass on graph with > 1000000 edges in the graph. #61
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Having flags would be great. Much better than hard coding it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Sep 5, 2018
Collaborator
Thanks. I'll add the flags. So far the impact would be minimal re: auk. I can only find 1 (2402) that has more than 1,000,000 edges but fewer than 50k nodes.
|
Thanks. I'll add the flags. So far the impact would be minimal re: auk. I can only find 1 (2402) that has more than 1,000,000 edges but fewer than 50k nodes. |
greebie commentedSep 5, 2018
Describe the bug
Set edge maximum amount to prevent larger nodes. Edge number to be determined.
To Reproduce
Some large networks have so many edges that they break sigmaJS.
Expected behavior
Do not potato browsers
Additional context
It may be preferred to let the user control the max number of edges and nodes. This can be a feature added another time.