Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: kiwiPy: Robust, high-volume, messaging for big-data and computational science workflows #2295

Closed
whedon opened this issue Jun 7, 2020 · 27 comments

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Jun 7, 2020

Submitting author: @muhrin (Martin Uhrin)
Repository: https://github.com/aiidateam/kiwipy
Version: v0.6.0
Editor: @danielskatz
Reviewers: @dghoshal-lbl, @uellue
Managing EiC: Kyle Niemeyer

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @muhrin. Currently, there isn't an JOSS editor assigned to your paper.

@muhrin if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Jun 7, 2020
@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 7, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 7, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.14 s (391.0 files/s, 41959.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          34            866            653           2385
Jupyter Notebook                 4              0            737            178
TeX                              1             13              0            172
SVG                              1             19              8            149
reStructuredText                 6            120            119            100
YAML                             3             16              5             75
Markdown                         1             18              0             45
Bourne Shell                     1             24              4             30
DOS Batch                        1              8              1             26
make                             1              4              6              9
INI                              1              0              0              5
-------------------------------------------------------------------------------
SUM:                            54           1088           1533           3174
-------------------------------------------------------------------------------


Statistical information for the repository '2295' was gathered on 2020/06/07.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Jason Eu                         1           226            177            2.25
Jason.Eu                         1             2              7            0.05
Martin Uhrin                   130         10609           6787           97.02
Sebastiaan Huber                19            81             40            0.67
cclauss                          1             1              1            0.01

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Jason.Eu                    135         6750.0         12.7               49.63
Martin Uhrin               3734           35.2          8.4               10.28
Sebastiaan Huber             35           43.2         15.6                2.86
@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 7, 2020

Reference check summary:

OK DOIs

- 10.1063/1.4812323 is OK
- 10.1007/s11837-013-0755-4 is OK
- 10.1016/j.commatsci.2012.02.005 is OK
- 10.1088/2515-7639/ab13bb is OK
- 10.1109/MCSE.2012.16 is OK
- 10.1002/cpe.3505 is OK
- 10.1016/j.commatsci.2015.09.013 is OK
- 10.21105/joss.01844 is OK
- 10.21105/joss.01844 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 7, 2020

@kyleniemeyer
Copy link

@kyleniemeyer kyleniemeyer commented Jun 7, 2020

👋 @muhrin - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS we've had > 60 papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

@muhrin
Copy link

@muhrin muhrin commented Jun 8, 2020

Thanks @kyleniemeyer, no worries regarding the backlog - we're looking forward to your review. I mention my coauthor, @sphuber, to bring him into the conversation.

@Kevin-Mattheus-Moerman
Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Jun 16, 2020

@poulson @harpolea @dpsanders could one of you handle this submission? Thanks

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 16, 2020

I'll take this one

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 16, 2020

@whedon assign me as editor

@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 16, 2020

OK, the editor is @danielskatz

@danielskatz danielskatz removed the waitlisted label Jun 16, 2020
@danielskatz
Copy link

@danielskatz danielskatz commented Jun 16, 2020

👋 @muhrin - if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list). I will also think about potential reviewers...

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 16, 2020

Also, the repository you entered when submitting (as shown at the top of the issue) is https://github.com/aiidateam/kiwipy.git - I'm going to change this to https://github.com/aiidateam/kiwipy unless you object...

@muhrin
Copy link

@muhrin muhrin commented Jun 16, 2020

Thanks Daniel. No objection re: repo change, this was a mistake.

I'll have a look at the list tomorrow and get back with some suitable candidates.

@muhrin
Copy link

@muhrin muhrin commented Jun 17, 2020

Here are some usernames that came up that I feel could be suitable reviewers:

colbrydi
cmbiwer
uellue
alvarolopez
dghoshal-lbl

My main criteria were looking for reviewers with python as a preferred language, then some experience of big-data/HPC/workflows (which is the main application for kiwiPy) followed by those who had HPC/cloud/distributed systems expertise.

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 17, 2020

👋 @dghoshal-lbl - would you be willing to review this submission for JOSS?

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 17, 2020

👋 @uellue - would you be willing to review this submission for JOSS?

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 17, 2020

👋 @cmbiwer - would you be willing to review this submission for JOSS?

@dghoshal-lbl
Copy link
Collaborator

@dghoshal-lbl dghoshal-lbl commented Jun 17, 2020

@danielskatz sure. I can review this submission.

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 17, 2020

Thanks @dghoshal-lbl - I'll assign you, but the review won't start until we get one more reviewer as well.

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 17, 2020

@whedon assign @dghoshal-lbl as reviewer

@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 17, 2020

OK, @dghoshal-lbl is now a reviewer

@uellue
Copy link
Collaborator

@uellue uellue commented Jun 17, 2020

👋 @uellue - would you be willing to review this submission for JOSS?

Yes, sure! :-)

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 17, 2020

Thank - I'll add you and we can get started

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 17, 2020

@whedon add @uellue as reviewer

@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 17, 2020

OK, @uellue is now a reviewer

@danielskatz
Copy link

@danielskatz danielskatz commented Jun 17, 2020

@whedon start review

@whedon
Copy link
Collaborator Author

@whedon whedon commented Jun 17, 2020

OK, I've started the review over in #2351.

@whedon whedon closed this Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.