Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractNote import issue with RDF.js and Embedded Metadata.js #2164

Open
vancleve opened this issue Apr 19, 2020 · 1 comment
Open

AbstractNote import issue with RDF.js and Embedded Metadata.js #2164

vancleve opened this issue Apr 19, 2020 · 1 comment

Comments

@vancleve
Copy link

@vancleve vancleve commented Apr 19, 2020

Running the Embedded Metadata.js translator on
https://www.nature.com/articles/ncomms14906
returns

 "abstractNote": "Advanced LIGO has detected gravitational waves from two binary black hole mergers, plus a merger candidate. Here the authors use the COMPAS code to show that all three events can be explained by a single evolutionary channel via a common envelope phase, and characterize the progenitor metallicity and masses."

which is not the Abstract, but rather the content of og:description.

From here,

newItem.abstractNote = getFirstResults(node, [n.eprints + "abstract",

it looks like the Facebook OpenGraph (og:description) description element takes precedence over description:
newItem.abstractNote = getFirstResults(node, [n.dc + "description", n.dcterms + "description"], true);

From the debug in Embedded Metadata.js, it looks like the RDF is being constructed with the correct abstract as:

http://purl.org/dc/elements/1.1/description=>During its first four months of taking data, Advanced LIGO has detected gravitational waves from two binary black hole mergers, GW150914 and GW151226, along with the statistically less significant binary black hole merger candidate LVT151012. Here we use the rapid binary population synthesis code COMPAS to show that all three events can be explained by a single evolutionary channel—classical isolated binary evolution via mass transfer including a common envelope phase. We show all three events could have formed in low-metallicity environments (Z=0.001) from progenitor binaries with typical total masses ≳160M⊙, ≳60M⊙ and ≳90M⊙, for GW150914, GW151226 and LVT151012, respectively. Advanced LIGO has detected gravitational waves from two binary black hole mergers, plus a merger candidate. Here the authors use the COMPAS code to show that all three events can be explained by a single evolutionary channel via a common envelope phase, and characterize the progenitor metallicity and masses.

So, is this a "bug" that should be fixed in RDF.js or Embedded Metadata.js or in Nature Publishing Group.js?

@adam3smith
Copy link
Collaborator

@adam3smith adam3smith commented May 10, 2020

I'm not sure this is a "bug" in the common sense of the word. As you note, the RDF translator is explicitly written to prefer og:description over dc:description and that's what's happening.

Having looked at this briefly, it looks to me that the reason for this is terribly convoluted, related to the use of dc.description in the Zotero RDF format (for the extra field).

This will require a more thorough dive than I'll be able to do in the coming months, I'm afraid, but I'll leave this ticket open for reference. I don't think the current behavior is correct -- I'd be surprised if dc: metadata isn't almost always better than og.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.