Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upadded runit.mass.R #87
Conversation
schymane
added some commits
Nov 10, 2018
This comment has been minimized.
This comment has been minimized.
Is this correct? I thought the JNI signature for object return values started with |
This comment has been minimized.
This comment has been minimized.
nope, wasn't and is reverted. |
schymane
added some commits
Nov 12, 2018
This comment has been minimized.
This comment has been minimized.
I've reverted the incorrect changes (didn't realise they came all the way through to here automatically) and added some unit tests for the molecular formulas. |
This comment has been minimized.
This comment has been minimized.
As for previous unit tests, I've commented out the ones that are either returning NPE or incorrect/inconsistent values (and just fixed a wrong NPE annotation). |
rajarshi
merged commit 5f60220
into
CDK-R:massfuncs
Nov 13, 2018
This comment has been minimized.
This comment has been minimized.
Interesting, I definitely directed all the runit.mass.R changes into your massfuncs branch my side...
On Tue, Nov 13, 2018 at 3:59 AM +0100, "Rajarshi Guha" <notifications@github.com<mailto:notifications@github.com>> wrote:
Unfortunately, this pull request is for master which doesn't have the get.mass function
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#87 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AD4a_TMZ0HEqlowFJ0CU0bUu4VcTphpIks5uujVygaJpZM4YZ5_r>.
|
This comment has been minimized.
This comment has been minimized.
Sorry, my bad - it was for the |
schymane commentedNov 12, 2018
I have added the basis for unit tests for all functions for a few major cases but commented out all the (many) tests that are currently generating NPEs